Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabNav component refactoring #900

Merged
merged 5 commits into from
Oct 21, 2019
Merged

TabNav component refactoring #900

merged 5 commits into from
Oct 21, 2019

Conversation

marynaKhromova
Copy link
Contributor

  • clean up and restructure the styles
  • remove redundant code

@marynaKhromova marynaKhromova added the enhancement New feature or request label Oct 16, 2019
@zarkosimic zarkosimic self-assigned this Oct 16, 2019
@pekura pekura self-assigned this Oct 17, 2019
zarkosimic
zarkosimic approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@JohannesDoberer JohannesDoberer merged commit 26c5604 into SAP:master Oct 21, 2019
@marynaKhromova marynaKhromova deleted the refactor-TabNav-component branch October 25, 2019 08:54
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@marynaKhromova @JohannesDoberer
TabNav component refactoring (SAP#900)
b2db48b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekura pekura pekura approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

Assignees

@pekura pekura

@zarkosimic zarkosimic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marynaKhromova @pekura @zarkosimic @JohannesDoberer