Copy to clipboard for code blocks #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # website/docs/src/luigi-config/extended/navigation.js
…nakhromova/luigi into 853-Create-styles-for-documentation
…-for-documentation
…naKhromova/luigi into 853-Create-styles-for-documentation
…naKhromova/luigi into marynaKhromova-853-Create-styles-for-documentation
maxmarkus
requested review from
alexandra-simeonova,
bszwarc and
hardl
as code owners
…nal-linking # Conflicts: # website/docs/package-lock.json # website/docs/src/unified-plugins/rehype-luigi-linkparser.js
…uigi into 919-dynamic-internal-linking
marynaKhromova
suggested changes
Nov 15, 2019
…to 962-copy-to-clipboard
# Conflicts: # website/docs/src/client.js # website/docs/src/unified-plugins/rehype-luigi-linkparser.js
…oard # Conflicts: # website/docs/scripts/markdown.unified-preview.js # website/docs/src/client.js # website/docs/src/routes/_layout.svelte # website/docs/src/services/markdown.service.js # website/docs/src/unified-plugins/rehype-luigi-linkparser.js
marynaKhromova
approved these changes
Nov 15, 2019
…oard # Conflicts: # website/docs/scripts/markdown.unified-preview.js # website/docs/src/client.js # website/docs/src/routes/_layout.svelte # website/docs/src/services/markdown.service.js # website/docs/src/unified-plugins/rehype-copy-to-clipboard.js # website/docs/src/unified-plugins/rehype-luigi-linkparser.js
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Nov 20, 2019
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Nov 26, 2019
* master: (275 commits) update luigi version (SAP#985) FAQ Documentation (SAP#982) Docu links leftovers (SAP#974) Bugfix invalid initial root navnode (SAP#979) Leftover documentation fixes (SAP#978) Navigate with anchors (SAP#976) remove jesusreal from codeowners, thanks for your great work in this project (SAP#980) Dynamically generate navigation (SAP#973) Copy to clipboard for code blocks (SAP#963) add link on landing page to luigi fiddle (SAP#968) Custom markdown attributes (SAP#967) Luigi architecture page (SAP#969) Dynamic internal linking (SAP#960) Update sitemap.xml (SAP#964) Luigi client installation document (SAP#957) Cm fix (SAP#952) Create styles for documentation (SAP#958) Update Luigi core dependency to npm 6.13.0 (SAP#953) Luigi example react (SAP#944) link fix (SAP#950) ... # Conflicts: # core/examples/luigi-sample-angular/src/assets/auth-mock/login-mock.html
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review after #958 has been merged and branch updated.
Created a rehype plugin that adds a copy to clipboard button to each
preblock (markdown code block), then using native browser text select and copying to copy to clipboard.No visual copied response implemented. Could be done as a further step.