Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change documentation link #984

Merged
merged 10 commits into from
Nov 29, 2019
Merged

change documentation link #984

merged 10 commits into from
Nov 29, 2019

Conversation

marynaKhromova
Copy link
Contributor

I've updated the documentation link on landingpage.

@marynaKhromova marynaKhromova added this to the Sprint 8 milestone Nov 21, 2019
@zarkosimic zarkosimic self-assigned this Nov 22, 2019
zarkosimic
zarkosimic approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohannesDoberer JohannesDoberer self-assigned this Nov 25, 2019
JohannesDoberer
JohannesDoberer reviewed Nov 25, 2019
View reviewed changes
website/landingpage/public/about.html
@@ -37,8 +37,7 @@
</li>
<li class="item">
<a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luigi/website/landingpage/public/about.html

Line 99 in df60c86

<li><a href="https://github.com/SAP/luigi/blob/master/docs/README.md" target="_blank">Read Documentation</a></li>

Do we need to change this as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! thank you :) done.

JohannesDoberer
JohannesDoberer approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@pekura pekura merged commit f50fbc1 into SAP:master Nov 29, 2019
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Dec 4, 2019
@JohannesDoberer
Merge branch 'master' into third-party-cookie-check
e2a6edd 
* master:
  change documentation link (SAP#984)
  no message (SAP#998)
  release v0.7.2 (SAP#997)
  Update Luigi core npm to 6.13.1 (SAP#990)
  Update INTERNAL-README.md (SAP#987)
  Edge browser back (SAP#992)
  Third party cookie check (SAP#970)
@marynaKhromova marynaKhromova deleted the update-documentation-link branch February 12, 2020 16:19
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@marynaKhromova @pekura
change documentation link (SAP#984)
47c3647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

Assignees

@JohannesDoberer JohannesDoberer

@zarkosimic zarkosimic

Labels
website
Projects
None yet
Milestone
Sprint 8
Development

Successfully merging this pull request may close these issues.
4 participants
@marynaKhromova @JohannesDoberer @zarkosimic @pekura