Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sapnwrfc-client.d.ts #244

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Update sapnwrfc-client.d.ts #244

merged 3 commits into from
Dec 15, 2021

Conversation

uxkjaer
Copy link
Member

@uxkjaer uxkjaer commented Dec 14, 2021

not all parameters for connection is needed. By adding partial, we won't get errors in typescript.

Fix #243

not all parameters for connection is needed. By adding partial, we won't get errors in typescript
@bsrdjan
Copy link
Member

bsrdjan commented Dec 15, 2021

Thank you @uxkjaer. Would you mind to move the fix here, so that type definitions will be automatically generated in future releases as well:
https://github.com/SAP/node-rfc/blob/main/src/ts/wrapper/sapnwrfc-client.ts#L170

@uxkjaer
Copy link
Member Author

uxkjaer commented Dec 15, 2021

Thank you @uxkjaer. Would you mind to move the fix here, so that type definitions will be automatically generated in future releases as well: https://github.com/SAP/node-rfc/blob/main/src/ts/wrapper/sapnwrfc-client.ts#L170

Hi @bsrdjan I've reverted the original fix and pushed it into the proposed spot. Thanks

@bsrdjan bsrdjan merged commit 6e3d1b0 into SAP:main Dec 15, 2021
@phhoef
Copy link

phhoef commented Mar 16, 2022

Hi @bsrdjan,

I've downloaded node-rfc version 2.5.1 and running in the exact same problem.
Typescript is complaining, that the other 125 properties are missing when only defining DEST. I looked in the sapnwrfc-client.ts file and noticed, that it is not defined partial.
Am I using a wrong version?

@bsrdjan bsrdjan self-assigned this Mar 18, 2022
@bsrdjan bsrdjan added the bug label Mar 18, 2022
@bsrdjan
Copy link
Member

bsrdjan commented Mar 18, 2022

It is a bug, will be fixed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in typescript on sapnwrfc-client.d.ts on RfcConnectionParameters
3 participants