Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build github.io with pandoc #316

Merged
merged 25 commits into from
Apr 11, 2024
Merged

Build github.io with pandoc #316

merged 25 commits into from
Apr 11, 2024

Conversation

HeikoTheissen
Copy link
Contributor

@HeikoTheissen HeikoTheissen commented Apr 10, 2024

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks convincing: how can I test it?

@HeikoTheissen
Copy link
Contributor Author

HeikoTheissen commented Apr 11, 2024

Looks convincing: how can I test it?

See build run and build result.

Or test locally with npm run pages and npm run serve-pages.

Copy link
Member

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There are still about a dozen poor-man's bullet items in Common.xml that need to be <li>ed

Copy link
Member

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did _site/.gitignore disappear?

Comment on lines 112 to 114
- Binding parameter is type of annotated entity set

- No non-binding parameters

- Return type is same as binding parameter type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed line breaks here mess up the "poor-man's bullet lists" as the converter expects \n\n in https://github.com/oasis-tcs/odata-vocabularies/blob/1887311d443c40067a3285f3e00ef077ae21c117/lib/csdl2markdown.js#L664

Copy link
Contributor Author

@HeikoTheissen HeikoTheissen Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works after I have bumped the odata-vocabularies dependency to the commit that introduces the pandoc-on-the-fly build.

@HeikoTheissen
Copy link
Contributor Author

Looks good.

There are still about a dozen poor-man's bullet items in Common.xml that need to be <li>ed

Cleaned up now.

Copy link
Member

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@HeikoTheissen HeikoTheissen merged commit efb8e9c into main Apr 11, 2024
3 checks passed
@HeikoTheissen HeikoTheissen deleted the tools/build-with-pandoc branch April 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants