Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright 1.46 #224

Merged
merged 7,471 commits into from
Oct 22, 2024
Merged

Playwright 1.46 #224

merged 7,471 commits into from
Oct 22, 2024

Conversation

tmbrbr
Copy link
Contributor

@tmbrbr tmbrbr commented Sep 9, 2024

Updating upstream versions to:

Fixes #221

moz-wptsync-bot and others added 30 commits March 15, 2024 12:24
… block-level table, a=testonly

Automatic update from web-platform-tests
End ongoing IFC when inserting anonymous block-level table

So that the table appears after preceding inline-level contents.
Fixes #31603.

--

wpt-commits: 2d1637ca539586606850a4473de97ee6f19383ea
wpt-pr: 45090
…s for web animations, a=testonly

Automatic update from web-platform-tests
Apply standard parsing of pseudo-elements for web animations

Note that for web-animations, using no-colons or single-colon already
works as specified, and the difference here is in making the argument
parser more forgiving (as per spec).

This is behind a flag, together with full parsing for getComputedStyle.
See I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/p-7KuUD_p20/m/fe8Iwb-IAAAJ

The following test already asserts the behavior with single/no colon, which doesn't change with this CL:

TEST=external/wpt/web-animations/interfaces/Animatable/animate.html

The newly added test (third_party/blink/web_tests/external/wpt/css/css-view-transitions/web-animations-api-parse-pseudo-argument.html) asserts
the new observable behavior, which only applies to pseudos with
arguments.

Bug: 328681375
Change-Id: I3a259dbcddd85d2c0a050ab0e2bef55e02973d32

Validate-Test-Flakiness: skip
Change-Id: I3a259dbcddd85d2c0a050ab0e2bef55e02973d32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5358740
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272463}

--

wpt-commits: 98be2c714090af958a73b3d75ff62d7b85f4cb97
wpt-pr: 45052
…o avoid spurious MISSING test results., a=testonly

Automatic update from web-platform-tests
Use clearer variable names in grid WPT to avoid spurious MISSING test results. (#45091)

Fixes web-platform-tests/interop#646

This patch improves WPT grid-shorthand-serialization.html to better distinguish
between the `cssText` function-param vs. the serialization of that string that
the test reads back from the style system.

As of this patch, we'll now use the function-param (not its serialization) when
generating the subtest "name" value that we pass to the test(...) function.
This makes for more consistent output and removes the possibility for
browser-specific serialization-quirks to influence the subtest-name, as
discussed in web-platform-tests/interop#646

The test continues to use the serialized value (under a new/clearer variable
name) in the assert_true() expression, though; this way, if the test fails, it
remains easy to see the actual strings that are involved in the `indexOf`
operation that's causing the test-failure.
--

wpt-commits: 227a77f3eac2653c34706d578bdd709b3897e962
wpt-pr: 45091
…ement, a=testonly

Automatic update from web-platform-tests
Add HandleInvokeInternal on HTMLDialogElement

This adds support for the experimental `invoketarget` behavior for
HTMLDialogElement.

See explainer section here:
https://open-ui.org/components/invokers.explainer/#defaults.

This introduces new behavior for HTMLDialogElements such that:

 - If an `invoketarget` points to a `<dialog>` (and the parent logic
   fell through):
    - If the `invokeaction` is `` (empty - the auto state) try to toggle the dialog as modal.
    - If the `invokeaction` is `close`, try to close the dialog
    - If the `invokeaction` is `showModal`, try to show the dialog as
      modal.

Bug: 1494810
Change-Id: I701e0e33780ba7787096201d02a50cd071febf4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987322
Reviewed-by: Mason Freed <masonf@chromium.org>
Auto-Submit: Keith Cirkel <chromium@keithcirkel.co.uk>
Reviewed-by: Luke <lwarlow@igalia.com>
Commit-Queue: Luke <lwarlow@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1272509}

--

wpt-commits: 65929ad7c472050cb0b32f7c295d6b774ce063cf
wpt-pr: 42827
…be cancelled on aborting fetch streaming upload"", a=testonly

Automatic update from web-platform-tests
Reapply "Reapply "ReadableStream should be cancelled on aborting fetch streaming upload""

This reverts commit 826c3cab0db8660bf355979664daa9475d855cef.

This CL reapplies the CL fixing the ci test failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/119114/test-results?sortby=&groupby=
(see the diff from Patchset#1)

TEST: third_party/blink/tools/run_wpt_tests.py --release -p chrome external/wpt/webdriver/tests/bidi/network/

Fixed: 40071725
Change-Id: I021c29e016bef9f3ef7c980fa038a13bdd9a0369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5363997
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272576}

--

wpt-commits: 5abfea3260af2a20a69606743d87b56fbc478315
wpt-pr: 45075
…mple2d op, a=testonly

Automatic update from web-platform-tests
[webnn] Add float32 tests for WebNN resample2d op (#41811)

* [webnn] Add float32 tests for WebNN resample2d op

* [webnn] Removed some downsample tests for resample2d

* [webnn] Rebased code

* [webnn] Add default ULP tolerance for resample2d on linear mode.
--

wpt-commits: efd25109bb53b515e720aedf4a7446511d406ccc
wpt-pr: 41811
…eResponse` test, a=testonly

Automatic update from web-platform-tests
[WebDriverBiDi] improve `network.continueResponse` test (#45083)

--

wpt-commits: c15acce5d2da2dd33814bc9ad5d237b0393efdfe
wpt-pr: 45083
…t the end of inline elements, a=testonly

Automatic update from web-platform-tests
Allow finishing anonymous inline-table at the end of inline elements

This avoids inserting it outside of its parent.

--

wpt-commits: 19ffb2b65f273878e09b8956dc4472016b1466d0
wpt-pr: 45093
…e WPT expectations, a=testonly

Automatic update from web-platform-tests
DOM: Correct script-in-script atomic move WPT expectations

This CL corrects the script-in-script insertion test, to assert that
when an "outer" script element (that has not yet been prepared/executed)
gets an "inner" script element inserted into it, the outer script runs
before the inner one.

This is a break in what the HTML Standard previously required, before
whatwg/html#10188.

R=nrosenthal@chromium.org

Bug: 40150299
Change-Id: If8cdce18a13678ac0646d81bc14850b2f26b6eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367667
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272720}

--

wpt-commits: e25a0c84dac911c78265c142ab9e178e3936fee2
wpt-pr: 45094
…ils, a=testonly

Automatic update from web-platform-tests
Retry emulator.wait_for_start() if it fails

--

wpt-commits: a4a6ea8eac94cfb6f3466a3aed5c0b3986ee0553
wpt-pr: 45084
…nto next fragmentainer, a=testonly

Automatic update from web-platform-tests
Make css grid not push content too far into next fragmentainer

CSS grid used to push content that would overflow a fragmentainer
way too far into the next fragmentainer since the fragmentainer
space got extended by the content's own space when it wasn't necessary

Bug: 327643792
Change-Id: I577efc886ab8c777b14d0119281527cb2d8b9727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370572
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1272916}

--

wpt-commits: 28c0ddc9977252eec982137274eb436bc0aa2c78
wpt-pr: 45099
…ent interface as deprecated., a=testonly

Automatic update from web-platform-tests
[css-scroll-snap-2] Mark obsolete SnapEvent interface as deprecated.

The new interface is described in [1].

[1]w3c/csswg-drafts#9515

Bug: 329111147
Change-Id: I1985757eed10d15433590e35438b83e4db09a092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369679
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272921}

--

wpt-commits: c9a1cb97473bb77fe4259d81a739f64e7f8ad167
wpt-pr: 45089
…fe4259d81a739f64e7f8ad167, a=testonly

MANUAL PUSH: wpt sync bot

wpt-head: c9a1cb97473bb77fe4259d81a739f64e7f8ad167
wpt-type: landing
…isk_space Glean probe. r=backup-reviewers,perry.mcmanis,kpatenio

Differential Revision: https://phabricator.services.mozilla.com/D204676
…sses. r=rhunt.

For the classes MWasmBinarySimd128, MWasmBinarySimd128WithConstant,
MWasmReplaceLaneSimd128, MWasmScalarToSimd128 and MWasmReduceSimd128, their
`congruentTo` method calls `ins->toMFoo()` without having previously
established that `ins` actually is an MFoo.  For these cases, the relevant
test, as performed by a call to `congruentIfOperandsEqual`, is moved earlier
in the sequence.

Additionally, class MWasmTernarySimd128 doesn't check its simdOp_ field.  This
is fixed.

Differential Revision: https://phabricator.services.mozilla.com/D204674
…url data after construction. r=dshin

ReplaceSync did this, but if you don't call Replace() / ReplaceSync()
after construction we end up with the Servo_StyleSheet_Empty which has a
dummy URL data.

Differential Revision: https://phabricator.services.mozilla.com/D204603
lsalzman and others added 17 commits April 5, 2024 20:35
ar -> b4d37327b39820f3169bb9b9b613f96ea48d00ca
cs -> 4e45324c27df1a2b284faa92f569736e7c14177d
dsb -> 82d5ae3cf66ee96f461a27d8073802ac1a61c792
el -> 22ab7ff93b039239218bdc9592a7944d572b4b9e
es-ES -> ba37303d99ac5b7bfa19d19085de59d932300bbc
hsb -> 49e9db6cad9b7bfc4f1674efa68ddb3f7ebe4a31
ja -> e7a4e3dfae9f263193befecdd5e95efed3a30259
ja-JP-mac -> 6a7a8218314e397ea975f8229d25946d71b59f93
lv -> 0f64a1f51d1db65ed999c63c39124af2f547c96c
nn-NO -> 1a0dd05416e684f4dde8e04a51e035ccc6110913
pl -> 6b35b3b8a145ba2369afdab589397a76441523e8
th -> d61fe3d680aaed5acc82321634d321b6874a7da7
…a=RyanVM

The test weren't spawning the DevToolsServer the same way as in production.
--start-debugger-server spawns the server in the distinct devtools global in order to be able to debug privileged compartment.

Original Revision: https://phabricator.services.mozilla.com/D206497

Differential Revision: https://phabricator.services.mozilla.com/D206877
…X_RELEASE_125_BASE a=release DONTBUILD CLOSED TREE
…3c2b967ba9 b47d1bc39abee49e9967968259bb0a6c1a4ede6c| CLOSED TREE DONTBUILD a=release
…X_RELEASE_124_END a=release DONTBUILD CLOSED TREE
…X_125_0_BUILD1 a=release CLOSED TREE DONTBUILD
Backed out changeset 937a51dbe70c (bug 1883775)
Backed out changeset d88ec0d14b41 (bug 1883123)
Backed out changeset 49cc33ed1599 (bug 1883123)
Backed out changeset b6dff3a3d41b (bug 1882228)
Backed out changeset 62677f25e495 (bug 1881662)
Backed out changeset ac4d7c08648c (bug 1881635)
Backed out changeset 3157eece201c (bug 1881360)
Backed out changeset c676fc5d89bc (bug 1848414)
Backed out changeset 5c6748ef5865 (bug 1848414)
Backed out changeset 672c3f18cb8b (bug 1848414)
Backed out changeset 2f4044201b9a (bug 1848414)
Backed out changeset ff5f23856542 (bug 1848414)
Backed out changeset f81e80cf062f (bug 1848414)
Backed out changeset d711a830a93e (bug 1848414)
Backed out changeset 62ab286ed401 (bug 1848414)
Backed out changeset 24143ec374ff (bug 1854868)
Backed out changeset 9c11a87d38fc (bug 1854868)
Backed out changeset d7341669eb0b (bug 1854868)
Backed out changeset b9753f244f18 (bug 1854868)
Backed out changeset 1e094e3ca992 (bug 1799332)
Backed out changeset 62d28922bd23 (bug 1799332)
Backed out changeset c7aa9b74be01 (bug 1799332)
Backed out changeset d8dd28c68304 (bug 1799332)
Backed out changeset a50eb05b0b0b (bug 1799332)
Backed out changeset 21e9f01c0021 (bug 1882322)

Differential Revision: https://phabricator.services.mozilla.com/D207508
@tmbrbr tmbrbr added upstream Issue related to upstream Firefox playwright Issues with playwright integration labels Sep 9, 2024
@tmbrbr tmbrbr self-assigned this Sep 9, 2024
@tmbrbr tmbrbr requested a review from leeN September 9, 2024 09:38
Copy link

cla-assistant bot commented Sep 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 19 committers have signed the CLA.

✅ tmbrbr
❌ issammani
❌ KershawChang
❌ Mozilla Releng Treescript
❌ abhishekmadan30
❌ rvandermeulen
❌ nuggetsnegin
❌ nordzilla
❌ mkaply
❌ ScottDowne
❌ makotokato
❌ squarewave
❌ aminomancer
❌ QwerkyQoder
❌ jandem
❌ ochameau
❌ lsalzman
❌ calixteman
❌ ncalexan


Mozilla Releng Treescript seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@leeN leeN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@tmbrbr
Copy link
Contributor Author

tmbrbr commented Oct 16, 2024

Using this as a test of the build checks - this should fail as the playwright patches should not apply.

@tmbrbr tmbrbr merged commit 121bf46 into SAP:main Oct 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playwright Issues with playwright integration upstream Issue related to upstream Firefox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Playwright v1.46