Upgrade Foxhound to Firefox Release 84 #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mer. r=dragana, a=RyanVM Due to various reasons (network change, temporary network congestion, etc) it may happen that we exceed the limit of TRR failures thus going into CONFIRM_FAILED state and setting the timer for automatic retry. When confirmation is not "skip" we want to reduce the amount of time as much as possible - so if it's a transient reason for the failures, we should retry as early as possible. This patch reduces the initial timer to 125 ms (down from 1000 ms). Exponential backoff is still in effect, so the only effect should be retrying earlier. We also turn it into a pref, so it's easy to experiment with it to find the perfect value. Depends on D96822 Differential Revision: https://phabricator.services.mozilla.com/D96823
…X_83_0_BUILD2 a=release CLOSED TREE DONTBUILD
…=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D97131
…X_83_0_RELEASE a=release CLOSED TREE DONTBUILD
…=jcristau Differential Revision: https://phabricator.services.mozilla.com/D97554
…. r=jcristau, a=npotb Differential Revision: https://phabricator.services.mozilla.com/D96409
… build/defines.sh. r=jcristau, a=npotb Differential Revision: https://phabricator.services.mozilla.com/D96410
…efault. r=prathiksha, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D97586
…. r=jrmuizel, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D97561
…red cache. r=gsvelto, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D97679
…RyanVM Differential Revision: https://phabricator.services.mozilla.com/D97360
…r=adw, a=jcristau We were restoring search mode after tab switch even if the destination tab had a valid pageproxystate. This was causing issues in the case where the user switched away from a tab that was still loading and had not yet called setURI. If the user switched back to that tab after it was done loading, we would re-enter search mode, using the page's URL as the search string. Making this change also requires storing pageproxystate differently. If we only made the change to setURI, we would sometimes not restore search mode when we should. If the user entered search mode with an empty string, userTypedValue would never be updated and it would still be the page URL. After the user switched from, then to, that tab, we'd call setURI. setURI would restore userTypedValue, which would be the page URL. Since that page now had a valid pageproxystate, we would not restore search mode. Now we update userTypedValue when we enter search mode, so we restore search mode properly even when there is no search string. Differential Revision: https://phabricator.services.mozilla.com/D97798
…abilitiesW calls. r=jfkthame, a=jcristau This is to prevent threading issues that some drivers seem to have when they access their own default DEVMODE internally. Differential Revision: https://phabricator.services.mozilla.com/D97789
…s. r=KrisWright, a=jcristau This patch ensures that crash reports for main process crashes always have memory annotations populated. It also cleans up the relevant code, removing support for Windows 32-bit time_t values. The tests that did only cover Windows have been modified to also run on macOS and Linux. Differential Revision: https://phabricator.services.mozilla.com/D97667
…=jcristau Differential Revision: https://phabricator.services.mozilla.com/D97874
… around a macOS bug (FB8828157) that causes the panel shadow to be missing. r=dao, a=jcristau The fade-out animation is kept. To work around the bug, the first paint of the panel window needs to be done at full window opacity. Reducing the window opacity after the shadow has been computed works correctly. Differential Revision: https://phabricator.services.mozilla.com/D97863
This commit adds a rosetta status to three different places: - `nsSystemInfo`, to check for rosetta status per apple specifications. We also use the same check in `nsCocoaFeatures` in D89961. - `Troubleshoot.jsm`, to add rosetta status data (should it exist) to use in about:support - `About:Support` itself, if the device is running MacOS Differential Revision: https://phabricator.services.mozilla.com/D94930
The RDD process can no longer work without having access to win32k ; enabling this pref would lead to a crash on Nightly and failure to work elsewhere. Differential Revision: https://phabricator.services.mozilla.com/D97753
Differential Revision: https://phabricator.services.mozilla.com/D97897
lv -> cda6b84709795535948549c358f775a45d9554b0
lv -> e93d41821127599c9902015f50194e594a899450
lv -> 39ec7e411ff927ed09fbb03ef848aff1fa3455ac
el -> 8ca09ffb7fcca85556ae02019dbae4348c7c3122 hu -> 610760cd95e8dae7850ea53ade37d76953260085 lv -> 1e916dcbcba3863c3fe3801b39c2bd72ea22bcc1 pa-IN -> 96f26be624a02b62b279b51d639657a163ef0294
…alog. r=bobowen, a=RyanVM This was accidentally enabled when moving to the more modern print dialog API. Differential Revision: https://phabricator.services.mozilla.com/D97933
it -> 92af4591e7b2f093e560b4b93fd07df323e22f3b lv -> ead745121884d74bc3d73427efa9d0de9286dbd5
lv -> a4ff8846a2623d35c40592f658d451a36bb296f6
lv -> b2322a949c896a7f4ef71016ff83a3ebb00e8b97
lv -> 0b9e565d1fe13f76fb51945b1b2ab1f820a14798
ko -> a3c6459ce83b72a4e65cf8a39ca0cf712f508491 lv -> 3fd8adb8aeb622e163f292ee329de93563e53dcd
…X_RELEASE_83_END a=release DONTBUILD CLOSED TREE
…rt, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D98897
…X_84_0_BUILD1 a=release CLOSED TREE DONTBUILD
…ptor. r=glandium, a=RyanVM In Bug 1671424 we changed the way we configure firefox and it broke the codeql database generation job. This job wraps the entire build process in a way similar to codeql --command="./mach build" Specifically, the previous way we executed the configure shell script made codeql disable itself because it was named configure (codeql disables itself during configuration.) codeql injects via LD_PRELOAD, and it opens a configuration file and a logging file (getting fd 3 and 4 respectively.) autoconf grabs file descriptor 4 and uses it a temporary redirection point either to a file or stdout. When it does so, it closes the original file descriptor 4 and points it at the new location, which also affects the codeql code, resulting in undesired logging output going into the configure script. Because this file descriptor trick is only used to avoid duplicating a few lines of code, I removed the trick and duplicated the code. Differential Revision: https://phabricator.services.mozilla.com/D98642
…ta and release. r=drno a=test-only More details about the underlying issue in bug 1526207. Differential Revision: https://phabricator.services.mozilla.com/D98963
…d, a=RyanVM Due to rendering issues reported on a Mali-G77, disable partial present on all Mali-Gxx devices. Differential Revision: https://phabricator.services.mozilla.com/D99216
…=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D99327
…ferences; r=zbraniecki, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D99162
…X_84_0_BUILD2 a=release CLOSED TREE DONTBUILD
…mikedeboer, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D99213
…X_84_0_BUILD3 a=release CLOSED TREE DONTBUILD
…=jcristau Differential Revision: https://phabricator.services.mozilla.com/D99660
…X_84_0_RELEASE a=release CLOSED TREE DONTBUILD
* tag 'firefox_84_release': (17258 commits) No bug - Tagging 98507f230e7442065b287ced065ac77d4d8ea35d with FIREFOX_84_0_RELEASE a=release CLOSED TREE DONTBUILD No Bug, mozilla-release repo-update remote-settings - a=repo-update r=jcristau No bug - Tagging 98507f230e7442065b287ced065ac77d4d8ea35d with FIREFOX_84_0_BUILD3 a=release CLOSED TREE DONTBUILD Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer, a=RyanVM No bug - Tagging c513faba0ecb007328f05db3a98e3ba1aba7f10f with FIREFOX_84_0_BUILD2 a=release CLOSED TREE DONTBUILD Bug 1681428 - back out highlights and logo changes. r=thecount, a=RyanVM Bug 1676474 - Disable webrender partial present on Mali-Gxx. r=aosmond, a=RyanVM Bug 1681251 - Return AUTF8String from GetDateTimePattern in mozIOSPreferences; r=zbraniecki, a=RyanVM No Bug, mozilla-release repo-update remote-settings - a=repo-update r=RyanVM Bug 1680528 - set several webrtc/mediacapturing test as passing on beta and release. r=drno a=test-only Bug 1677797 - Change autoconf to avoid using a hard-coded file descriptor. r=glandium, a=RyanVM No bug - Tagging 6cf020352b4e350ab6b84253620652d55cdd0b60 with FIREFOX_84_0_BUILD1 a=release CLOSED TREE DONTBUILD Backed out changeset 346a46a93b30 (bug 1680299) to have universal builds. a=RyanVM Bug 1680299 - Turn the mac shippable build back into an x64_64-only build. r=glandium, a=RyanVM Bug 1681022 - Ignore flex-basis: content on a table wrapper. r=dholbert, a=RyanVM Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release No bug - tagging a42ea3aab3e467141d56b5c299749ee842cd3c41 with FIREFOX_RELEASE_83_END a=release DONTBUILD CLOSED TREE Preserve old tags after debusetparents. CLOSED TREE DONTBUILD a=release No bug - tagging 87ab4da1b9f786db1f5c6633357cbe2ee1ca562e with FIREFOX_RELEASE_84_BASE a=release DONTBUILD CLOSED TREE no bug - Bumping Firefox l10n changesets r=release a=l10n-bump ...
* merge_foxhound_r84: (17259 commits) Attempt to fix taint loss in URL Parsing No bug - Tagging 98507f230e7442065b287ced065ac77d4d8ea35d with FIREFOX_84_0_RELEASE a=release CLOSED TREE DONTBUILD No Bug, mozilla-release repo-update remote-settings - a=repo-update r=jcristau No bug - Tagging 98507f230e7442065b287ced065ac77d4d8ea35d with FIREFOX_84_0_BUILD3 a=release CLOSED TREE DONTBUILD Bug 1681328 - add more domains for Amazon and eBay tippytop icons. r=mikedeboer, a=RyanVM No bug - Tagging c513faba0ecb007328f05db3a98e3ba1aba7f10f with FIREFOX_84_0_BUILD2 a=release CLOSED TREE DONTBUILD Bug 1681428 - back out highlights and logo changes. r=thecount, a=RyanVM Bug 1676474 - Disable webrender partial present on Mali-Gxx. r=aosmond, a=RyanVM Bug 1681251 - Return AUTF8String from GetDateTimePattern in mozIOSPreferences; r=zbraniecki, a=RyanVM No Bug, mozilla-release repo-update remote-settings - a=repo-update r=RyanVM Bug 1680528 - set several webrtc/mediacapturing test as passing on beta and release. r=drno a=test-only Bug 1677797 - Change autoconf to avoid using a hard-coded file descriptor. r=glandium, a=RyanVM No bug - Tagging 6cf020352b4e350ab6b84253620652d55cdd0b60 with FIREFOX_84_0_BUILD1 a=release CLOSED TREE DONTBUILD Backed out changeset 346a46a93b30 (bug 1680299) to have universal builds. a=RyanVM Bug 1680299 - Turn the mac shippable build back into an x64_64-only build. r=glandium, a=RyanVM Bug 1681022 - Ignore flex-basis: content on a table wrapper. r=dholbert, a=RyanVM Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release No bug - tagging a42ea3aab3e467141d56b5c299749ee842cd3c41 with FIREFOX_RELEASE_83_END a=release DONTBUILD CLOSED TREE Preserve old tags after debusetparents. CLOSED TREE DONTBUILD a=release No bug - tagging 87ab4da1b9f786db1f5c6633357cbe2ee1ca562e with FIREFOX_RELEASE_84_BASE a=release DONTBUILD CLOSED TREE ...
|
This PR was done by merging with firefox main branch rather than the release branch. I have opened PR #9 as an alternative to address this. |
|
I have added instructions on how to update to upstream firefox code here: https://github.com/SAP/project-foxhound/wiki/Updating-from-upstream-Firefox Hopefully this will avoid confusion in the future! |
tmbrbr
referenced
this pull request
in tmbrbr/project-foxhound
Mar 15, 2024
…chevobbe Just starting up a debug build you will get 40 copies of this printed. The uri that we fail to get host of is about:newtab. One stack looks like this #2: mozilla::BasePrincipal::GetIsLoopbackHost(bool*) #3: mozilla::net::LoadInfo::LoadInfo(nsIPrincipal*, nsIPrincipal*, nsINode*, unsigned int, nsIContentPolicy::nsContentPolicyType, mozilla::Maybe<mozilla::dom::ClientInfo> const&, mozilla::Maybe<mozilla::dom::ServiceWorkerDescriptor> const&, unsigned int, bool #4: ShouldLoadCachedImage(imgRequest*, mozilla::dom::Document*, nsIPrincipal*, nsIContentPolicy::nsContentPolicyType, bool) #5: imgLoader::LoadImage(nsIURI*, nsIURI*, nsIReferrerInfo*, nsIPrincipal*, unsigned long long, nsILoadGroup*, imgINotificationObserver*, nsINode*, mozilla::dom::Document*, unsigned int, nsISupports*, nsIContentPolicy::nsContentPolicyType, nsTSubstring<char16 #6: nsContentUtils::LoadImage(nsIURI*, nsINode*, mozilla::dom::Document*, nsIPrincipal*, unsigned long long, nsIReferrerInfo*, imgINotificationObserver*, int, nsTSubstring<char16_t> const&, imgRequestProxy**, nsIContentPolicy::nsContentPolicyType, bool, bool, #7: mozilla::css::ImageLoader::LoadImage(mozilla::StyleComputedUrl const&, mozilla::dom::Document&) #8: mozilla::StyleComputedUrl::ResolveImage(mozilla::dom::Document&, mozilla::StyleComputedUrl const*) #9: nsStyleImageLayers::ResolveImages(mozilla::dom::Document&, nsStyleImageLayers const*) #10: mozilla::ComputedStyle::StartImageLoads(mozilla::dom::Document&, mozilla::ComputedStyle const*) Differential Revision: https://phabricator.services.mozilla.com/D193349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to update Foxhound to be based on Firefox r84.
This improves compatibility with newer C/C++ Compiler versions and is a first step to get Foxhound in line with mainline Firefox.
This requires some reviewing and some more testing :)
One change is that the preferences (enable/disable automatic URL encoding to match Internet Explorer behavior) are now static, therefore have to be changed before starting Foxhound. This should be easily adaptable if this is an issue.
Cheers,
David