Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config to reset view to top on navigation #12546

Merged
merged 5 commits into from
May 27, 2021
Merged

Conversation

Zeyber
Copy link
Contributor

@Zeyber Zeyber commented May 26, 2021

Closes: #10143

@Zeyber
Copy link
Contributor Author

Zeyber commented May 26, 2021

To test:

Set view and focus configs. Switch between BREAKPOINT values and boolean true/false to test features work as intended.

Example:
app.module.ts

provideConfig({
      keyboardFocus: {
        enableResetViewOnNavigate: [BREAKPOINT.xs, BREAKPOINT.sm],
        enableResetFocusOnNavigate: true,
      },
    }),

@cypress
Copy link

cypress bot commented May 26, 2021



Test summary

552 0 17 0Flakiness 1


Run details

Project spartacus
Status Passed
Commit 1d91717 ℹ️
Started May 27, 2021 8:11 AM
Ended May 27, 2021 8:21 AM
Duration 09:36 💡
OS Linux Ubuntu - 18.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/regression/cart.e2e-spec.ts Flakiness
1 ... > should use existing cart when adding new entries

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Matejk00 Matejk00 self-requested a review May 26, 2021 13:08
Matejk00
Matejk00 previously approved these changes May 27, 2021
@github-actions
Copy link
Contributor

Hosting service deployment

❗ Spartacus deployment failed ( ERR Failed to execute command [application deploy] due to: Error: Deploy
Failed. Could not generate environment or presigned URL.
Response code: 500
Message: Could not deploy new application, the limit: 10 for the
tenant: spartacus has been reached
Type: internal_service_error

). Check job logs for details.)

@Matejk00 Matejk00 self-requested a review May 27, 2021 08:20
@github-actions
Copy link
Contributor

Public API changes

✔️ Nothing changed in analyzed entry points.

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/account/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/profile/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

@Zeyber Zeyber merged commit f9faf0e into develop May 27, 2021
@Zeyber Zeyber deleted the feature/GH-10143-1 branch May 27, 2021 09:02
@Zeyber Zeyber temporarily deployed to dev May 27, 2021 09:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto scroll to middle or bottom of the page when navigating to new page.
2 participants