Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] replaceVersion/Copyright: Also process test-resources #693

Merged
merged 5 commits into from
Feb 14, 2022
Merged

[FEATURE] replaceVersion/Copyright: Also process test-resources #693

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b5c634
[FEATURE] replaceVersion/Copyright: Also process test-resources
matz3 Jan 24, 2022
c340512
Add more relevant file patterns
matz3 Feb 8, 2022
ad4c9b4
Version replacement in css files is not needed
matz3 Feb 11, 2022
3787032
Add *.html pattern for version replacement
matz3 Feb 14, 2022
dd91f32
Revert ThemeLibraryBuilder changes
matz3 Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/types/library/LibraryBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class LibraryBuilder extends AbstractBuilder {
workspace: resourceCollections.workspace,
options: {
copyright: project.metadata.copyright,
pattern: "/resources/**/*.{js,library,less,theme}"
pattern: "/**/*.{js,library,css,less,theme,html}"
}
});
});
Expand All @@ -38,7 +38,7 @@ class LibraryBuilder extends AbstractBuilder {
workspace: resourceCollections.workspace,
options: {
version: project.version,
pattern: "/resources/**/*.{js,json,library,less,theme}"
pattern: "/**/*.{js,json,library,less,theme}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add html extension here

}
});
});
Expand Down
4 changes: 2 additions & 2 deletions lib/types/themeLibrary/ThemeLibraryBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class ThemeLibraryBuilder extends AbstractBuilder {
workspace: resourceCollections.workspace,
options: {
copyright: project.metadata.copyright,
pattern: "/resources/**/*.{less,theme}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now there's no need to extend the patterns for theme libraries. So this change should be reverted. Or what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's revert this for theme libraries. It's unlikely to be required for .less and .theme files in a theme's test-resources

pattern: "/**/*.{less,theme}"
}
});
});
Expand All @@ -18,7 +18,7 @@ class ThemeLibraryBuilder extends AbstractBuilder {
workspace: resourceCollections.workspace,
options: {
version: project.version,
pattern: "/resources/**/*.{less,theme}"
pattern: "/**/*.{less,theme}"
}
});
});
Expand Down