Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] SourceMaps follow-up #709

Merged
merged 13 commits into from
Mar 10, 2022
Merged

[INTERNAL] SourceMaps follow-up #709

merged 13 commits into from
Mar 10, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Feb 24, 2022 •
edited
Loading

Follow-up of #695

@matz3 matz3 requested a review from RandomByte February 24, 2022 16:51
@coveralls
Copy link

coveralls commented Feb 24, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 94.816% when pulling 267fafc on next-sourcemaps-follow-up into 0c9fec6 on next.

@matz3 matz3 mentioned this pull request Feb 25, 2022
Merged
@matz3 matz3 marked this pull request as ready for review March 9, 2022 13:23
@matz3 matz3 requested review from flovogt and removed request for RandomByte March 9, 2022 13:23
flovogt
flovogt reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things. Might be non relevant

lib/processors/minifier.js Outdated Show resolved Hide resolved
test/lib/processors/minifier.js Show resolved Hide resolved
test/lib/processors/minifier.js Show resolved Hide resolved
test/lib/processors/minifier.js Show resolved Hide resolved
test/lib/processors/minifier.js Show resolved Hide resolved
test/lib/tasks/minify.js Show resolved Hide resolved
test/lib/tasks/minify.js Show resolved Hide resolved
@matz3 matz3 requested a review from flovogt March 10, 2022 11:03
flovogt
flovogt approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 merged commit daa2943 into next Mar 10, 2022
@matz3 matz3 deleted the next-sourcemaps-follow-up branch March 10, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flovogt flovogt flovogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @coveralls @flovogt