Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] generateThemeDesignerResources task: Create css_variables.less #730

Merged
merged 7 commits into from
Apr 14, 2022
Merged

[FEATURE] generateThemeDesignerResources task: Create css_variables.less #730

merged 7 commits into from
Apr 14, 2022

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Apr 6, 2022 •
edited
Loading

[FEATURE] Enhance task generateThemeDesignerResources.js to create css_variables.less files.
BLI: CPOUI5FOUNDATION-487

@flovogt flovogt requested a review from matz3 April 6, 2022 12:54
@matz3 matz3 changed the base branch from master to next April 6, 2022 14:34
@flovogt flovogt changed the title css variables enhancement [FEATURE] Enhance task generateThemeDesignerResources.js to create css_variables.less files Apr 7, 2022
@coveralls
Copy link

coveralls commented Apr 8, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 94.837% when pulling a78f753 on css-variables-enhancement into d2c269f on next.

@flovogt
Copy link
Member Author

flovogt commented Apr 8, 2022

Line https://github.com/SAP/ui5-builder/pull/730/files#diff-92c6913aec2b1a1b12c249189bafc7a0abbe5ccee607f72e847023916ed58796L59 and the following lines are creating a complete new .theming file. So, the existing theming file is ignored is this desired?

@matz3
Copy link
Member

matz3 commented Apr 8, 2022

Yes, the .theming file is either generated or copied from the sap/ui/core namespace. If it exists in the sources it will be overwritten.

@flovogt flovogt force-pushed the css-variables-enhancement branch from 3a99539 to 5b390a3 Compare April 13, 2022 05:22
@flovogt flovogt force-pushed the css-variables-enhancement branch from 5b390a3 to a78f753 Compare April 13, 2022 05:49
@matz3 matz3 changed the title [FEATURE] Enhance task generateThemeDesignerResources.js to create css_variables.less files [FEATURE] generateThemeDesignerResources task: Create css_variables.less Apr 13, 2022
@flovogt flovogt merged commit 34e69be into next Apr 14, 2022
@flovogt flovogt deleted the css-variables-enhancement branch April 14, 2022 08:35
This was referenced May 4, 2022
Closed
Closed
@matz3 matz3 mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flovogt @coveralls @matz3