Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Optimise themeBuild with workerpool via fsinterface #925

Merged
merged 59 commits into from
Jul 25, 2023
Merged

[INTERNAL] Optimise themeBuild with workerpool via fsinterface #925

merged 59 commits into from
Jul 25, 2023

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Jul 14, 2023 •
edited
Loading

JIRA: CPOUI5FOUNDATION-614

This change enhances #914 with a fsInterface like objects that "read" the information through postMessages via MessageChannel -> MessagePort

d3xter666 and others added 22 commits July 11, 2023 10:21
@d3xter666
Integrate workerpool
dd06b64 
Still not functional! Needs promises to be reworked into transferable objects
@d3xter666
Use Adaptors to transfer content
fa52d6b
@d3xter666
Make it work
b3ebec0
@d3xter666
Make it work with the pool
13d1f00
@d3xter666
Remove console.log-s
7ecba2b
@d3xter666
Parallelize per library.source.less
39bf701
@d3xter666
Cache transferable resources
afeda2e
@d3xter666
Stash to FS
e4a32b4
@d3xter666
Make it work with Transferable objects
80ec516
@d3xter666
Bugfixes
5202393
@d3xter666
Modify tests for the new workerpool interface
18be852
@d3xter666
Align build results with main branch
8de95b6
@d3xter666
Provide correct resources to the pool threads
339e3c7
@d3xter666
useWorkers=false by default
b5e6ddc
@d3xter666
Add some comments
9a5b7a0
@d3xter666
Update docs
c67a0f1
@d3xter666 @matz3
Update lib/processors/themeBuilderWorker.js
e92e803 
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
@d3xter666
Address code comments
5173ac6
@d3xter666
Use different flows for workers and sequential build
eca6fde
@d3xter666
Align types
4ef2d11
@d3xter666
Revert tests to initial state and make them pass
7197ae2
@d3xter666
Add tests for the worker
67616b4
@d3xter666 d3xter666 requested review from matz3 and a team July 14, 2023 11:39
@d3xter666 d3xter666 force-pushed the workerpool-fsinterface branch from 34e1986 to 0df03d5 Compare July 17, 2023 08:08
@d3xter666 d3xter666 requested a review from RandomByte July 17, 2023 09:27
@d3xter666
Copy link
Contributor Author

Current build fails, because of the taskUtil that is provided in most of the cases, so the workerpool execution becomes there the new "default". I'll adjust those tests later

@d3xter666 d3xter666 requested a review from matz3 July 21, 2023 11:06
RandomByte
RandomByte requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good!

lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/tasks/buildThemes.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
d3xter666 and others added 10 commits July 25, 2023 09:21
@d3xter666 @RandomByte
Update lib/processors/themeBuilderWorker.js
2564da9 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666 @RandomByte
Update lib/processors/themeBuilderWorker.js
1c9f46d 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666 @RandomByte
Update lib/processors/themeBuilderWorker.js
d17fc24 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666 @RandomByte
Update lib/processors/themeBuilderWorker.js
590875d 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666 @RandomByte
Update lib/processors/themeBuilderWorker.js
bbdaea8 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666 @RandomByte
Update lib/tasks/buildThemes.js
a65ae70 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666
Fix renames
8ca2062
@d3xter666
Fix tests
7d4f974
@d3xter666
Reorder code
831e3ea
@d3xter666
Remove redundant actions from fsInterfaces
ebf2ca0
@d3xter666 d3xter666 requested a review from RandomByte July 25, 2023 09:29
RandomByte
RandomByte previously approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments which we could also tackle later, great work 🚀

lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
lib/processors/themeBuilderWorker.js Outdated Show resolved Hide resolved
@d3xter666 @RandomByte
Update lib/processors/themeBuilderWorker.js
1048c44 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
RandomByte
RandomByte previously approved these changes Jul 25, 2023
View reviewed changes
@d3xter666 d3xter666 merged commit 195191e into main Jul 25, 2023
@d3xter666 d3xter666 deleted the workerpool-fsinterface branch July 25, 2023 14:57
@matz3 matz3 mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@matz3 matz3 Awaiting requested review from matz3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d3xter666 @coveralls @matz3 @RandomByte