[FIX] adapters/Memory: Return cloned resources #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
fix-memory-adapter
branch
from
f1e522f to
09e6ba2
Compare
|
Missing tests |
|
True. I've just made sure that existing tests do not break, but we should also have new tests. I'll take care of it. |
|
Rebased + added tests |
RandomByte
approved these changes
Jun 4, 2020
|
As discussed today, we should also clone on write in order to have a similar behavior as with the FS Adapter where for example a resources content can't be changed after it has been written. On read however, we can use the createStream parameter to skip copying a resources content. |
RandomByte
added a commit
that referenced
this pull request
Jul 29, 2020
This reverts commit 7bf3c6a.
RandomByte
added a commit
that referenced
this pull request
Jul 30, 2020
This reverts commit 7bf3c6a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist