Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for spec version 2.0 #277

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Conversation

svbender
Copy link
Contributor

BREAKING CHANGE:
Support for spec version 2.0 in
ui5Framework translator and projectPreprocessor.

BREAKING CHANGE:
Support for spec version 2.0 in
ui5Framework translator and projectPreprocessor.
@svbender svbender requested review from matz3 and RandomByte March 19, 2020 11:14
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2020

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 19, 2020

Coverage Status

Coverage increased (+0.07%) to 88.462% when pulling 3486fa7 on spec-version-2-support into 34d0753 on master.

@RandomByte
Copy link
Member

Please also add new tests for specVersion 2.0 in test/lib/extension.js and test/lib/projectPreprocessor.js as done here: https://github.com/SAP/ui5-project/pull/252/files

@matz3 matz3 mentioned this pull request Mar 20, 2020
3 tasks
lib/translators/ui5Framework.js Outdated Show resolved Hide resolved
@RandomByte
Copy link
Member

This is actually not a breaking change but a [FEATURE]. Either change the commit message in a rebase/squash and force push or remember to change it when squash and merging this PR

@svbender svbender changed the title [BREAKING] Support for spec version 2.0 [FEATURE] Support for spec version 2.0 Mar 20, 2020
@svbender svbender merged commit 770a56f into master Mar 20, 2020
@svbender svbender deleted the spec-version-2-support branch March 20, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants