Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Initial refactoring for introducing a Project class #394

Closed
wants to merge 99 commits into from
Closed

[INTERNAL] Initial refactoring for introducing a Project class #394

wants to merge 99 commits into from

Commits on May 18, 2022

  1. [INTERNAL] Initial refactoring for introducing a Project class

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    153944a View commit details
    Browse the repository at this point in the history

  2. Refactor Configuration into a single Class and create AbstractSpecifi… 

    …cation
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    74d0a7d View commit details
    Browse the repository at this point in the history

  3. Minor cleanup and fix tests

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    0a697dc View commit details
    Browse the repository at this point in the history

  4. projectGraphFromTree: Allow for node-level configuration parameters

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    d35e498 View commit details
    Browse the repository at this point in the history

  5. Upgrade fixtures to specVersion 2.3

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    f8d75b4 View commit details
    Browse the repository at this point in the history

  6. Limit Module API to specVersions >= 2.0 

    Add validation
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    db80a02 View commit details
    Browse the repository at this point in the history

  7. Process modules once per ID 

    Finish transfer of projectPreprocessor tests to projectGraphFromTree
tests
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    98854ec View commit details
    Browse the repository at this point in the history

  8. Add ProjectGraph tests

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    3b59a1b View commit details
    Browse the repository at this point in the history

  9. Refactor Module. Add support for dependency and collection shims

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    6bed2f0 View commit details
    Browse the repository at this point in the history

  10. Add extension support to ProjectGraph

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4f08298 View commit details
    Browse the repository at this point in the history

  11. JSdoc and test cleanup

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    035688f View commit details
    Browse the repository at this point in the history

  12. projectGraphFromTree: Add parameter to use an existing graph 

    Not sure whether this is actually useful in the long run
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    35dd0d7 View commit details
    Browse the repository at this point in the history

  13. Enhance normalizer and ui5Framework translator for project graph

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a7a3f55 View commit details
    Browse the repository at this point in the history

  14. Use object-spread operator instead of Object.assign 

    For no particular reason
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4342fc7 View commit details
    Browse the repository at this point in the history

  15. Revert "projectGraphFromTree: Add parameter to use an existing graph" 

    No use case yet

This reverts commit 9332424.
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4295888 View commit details
    Browse the repository at this point in the history

  16. Add ProjectGraph#getAllExtensions plus tests

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    7a7ad31 View commit details
    Browse the repository at this point in the history

  17. Split graph-agnostic ui5Framework implementation into separate file

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    668ae9e View commit details
    Browse the repository at this point in the history

  18. Introduce projectGraphFromDirectory as normalizer successor

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    acd32fd View commit details
    Browse the repository at this point in the history

  19. Fix collection shim handling

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    7eb4ce9 View commit details
    Browse the repository at this point in the history

  20. ProjectGraph: Add seal function

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    c4926c0 View commit details
    Browse the repository at this point in the history

  21. ProjectGraph: Projects must not depend on themselves

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    e8114f2 View commit details
    Browse the repository at this point in the history

  22. Implement optional dependencies, npm provider

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    f841562 View commit details
    Browse the repository at this point in the history

  23. ProjectGraph: No need to remove resolved optional dependencies from a… 

    …djacency list
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    518ee89 View commit details
    Browse the repository at this point in the history

  24. Resolve a bunch of npm tests

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    00430ba View commit details
    Browse the repository at this point in the history

  25. npm provider: Improve error message for unresolved modules

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    707004d View commit details
    Browse the repository at this point in the history

  26. Merge Configuration and Specification into one entity 

    Implement full Application spec
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    db2d45a View commit details
    Browse the repository at this point in the history

  27. Cleanup

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    70f00cb View commit details
    Browse the repository at this point in the history

  28. Add all missing types and adopt most tests

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    386b568 View commit details
    Browse the repository at this point in the history

  29. JSDoc cleanup

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    0ddf695 View commit details
    Browse the repository at this point in the history

  30. Specifications: Align reader getters

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    e827c75 View commit details
    Browse the repository at this point in the history

  31. ui5Framework provider: Fix framework dep collection

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    aa832dd View commit details
    Browse the repository at this point in the history

  32. projectGraphBuilder: Fix check for already qualified application proj… 

    …ects

If the already qualified project is visited again, it should not be
skipped but handled like any other duplicate. This change is mainly to
prevent the irritating log message indicating that the same project
already qualified as the application project but is ignored.
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    55242dc View commit details
    Browse the repository at this point in the history

  33. Remove obsolete lib/Specifications.js

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    0bf6e0f View commit details
    Browse the repository at this point in the history

  34. Collection handling: Ignore projects of collections 

    To be compatible with the current behavior of the projectPreprocessor.
Apparently the open.fe setup relies on that.
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    1e471bd View commit details
    Browse the repository at this point in the history

  35. ProjectGraph: Only resolve optional dependencies if the target can be… 

    … reached from the root project

Checking for a non-optional dependency is not sufficient since that can
originate from a project which is optional itself (i.e. has no
non-optional dependency leading to it).
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    9f1ca5a View commit details
    Browse the repository at this point in the history

  36. Move legacy OpenUI5 theme library handling to graph.Module

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    aa6b5ae View commit details
    Browse the repository at this point in the history

  37. projectGraphBuilder: Wait for async resolution of optional dependencies

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    1343150 View commit details
    Browse the repository at this point in the history

  38. Refactor graph module structure

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    9631712 View commit details
    Browse the repository at this point in the history

  39. Fix typos, add comments

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    62714da View commit details
    Browse the repository at this point in the history

  40. First draft for improved resource access

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4920de0 View commit details
    Browse the repository at this point in the history

  41. Align Module and ThemeLibrary with resource access changes, cleanup

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5eda2bd View commit details
    Browse the repository at this point in the history

  42. Move extension types to separate sub-dir

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    7a8d390 View commit details
    Browse the repository at this point in the history

  43. Implement build mechanics

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    94f1d63 View commit details
    Browse the repository at this point in the history

  44. Implement build mechanics II

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    eb95577 View commit details
    Browse the repository at this point in the history

  45. Refactor AbstractReader#addTask API

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    620e6d1 View commit details
    Browse the repository at this point in the history

  46. Dynamically decide which projects to build based on user and task demand

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    411a509 View commit details
    Browse the repository at this point in the history

  47. Cleanup

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    8acf7d4 View commit details
    Browse the repository at this point in the history

  48. ApplicationBuilder: Build custom bundles in sequence 

    To ensure reproducibility, especially if one bundle excludes another.
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    ba2404b View commit details
    Browse the repository at this point in the history

  49. Implement archive metadata handling

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    453352d View commit details
    Browse the repository at this point in the history

  50. Cleanup: Remove old modules, transfer tests, fix JSDoc

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    55d6e44 View commit details
    Browse the repository at this point in the history

  51. Enhance archive integration tests

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    feea171 View commit details
    Browse the repository at this point in the history

  52. Take over tests for modules moved from ui5-builder

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    9c84e63 View commit details
    Browse the repository at this point in the history

  53. Specification: Allow spec versions 2.4, 2.5 and 2.6

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    26fe28f View commit details
    Browse the repository at this point in the history

  54. Apply changes from SAP/ui5-builder#741

    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    6d2881c View commit details
    Browse the repository at this point in the history

  55. Apply changes from SAP/ui5-builder#745 

    As well as SAP/ui5-builder#748
    @RandomByte
    RandomByte committed May 18, 2022
    Configuration menu
    Copy the full SHA
    3d2893a View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. ProjectGraph: Update JSDoc

    @RandomByte
    RandomByte committed May 20, 2022
    Configuration menu
    Copy the full SHA
    6a43242 View commit details
    Browse the repository at this point in the history

  2. package.json: Bump @ui5/fs alpha version

    @RandomByte
    RandomByte committed May 20, 2022
    Configuration menu
    Copy the full SHA
    2e980a8 View commit details
    Browse the repository at this point in the history

  3. Specifications: Update JSDoc

    @RandomByte
    RandomByte committed May 20, 2022
    Configuration menu
    Copy the full SHA
    cb2fa20 View commit details
    Browse the repository at this point in the history

  4. [INTERNAL] Project: Add missing #getCustomMiddleware API

    @RandomByte
    RandomByte committed May 20, 2022
    Configuration menu
    Copy the full SHA
    03f8b27 View commit details
    Browse the repository at this point in the history

  5. [INTERNAL] Fix several uses of legacy project.metadata.* attributes

    @RandomByte
    RandomByte committed May 20, 2022
    Configuration menu
    Copy the full SHA
    098d4eb View commit details
    Browse the repository at this point in the history

  6. [INTERNAL] AbstractBuilder: Fix specVersion selection for task interface 

    Use specVersion of the custom task, not of the project using it
    @RandomByte
    RandomByte committed May 20, 2022
    Configuration menu
    Copy the full SHA
    5cdf725 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. [INTERNAL] Extensions: Add getters for modules

    @RandomByte
    RandomByte committed May 23, 2022
    Configuration menu
    Copy the full SHA
    5a12078 View commit details
    Browse the repository at this point in the history

  2. [INTERNAL] Transfer formatter tests from ui5-builder I

    @RandomByte
    RandomByte committed May 23, 2022
    Configuration menu
    Copy the full SHA
    cd70fce View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. [INTERNAL] generateProjectGraph: Add option to ignore framework deps 

    For example required by UI5 CLI add/remove/use commands which only
require the configured root project and no framework dependencies
    @RandomByte
    RandomByte committed May 24, 2022
    Configuration menu
    Copy the full SHA
    2426642 View commit details
    Browse the repository at this point in the history

  2. LibraryBuilder: Pass namespace to generateJsdoc task

    @matz3
    matz3 committed May 24, 2022
    Configuration menu
    Copy the full SHA
    1f838b7 View commit details
    Browse the repository at this point in the history

  3. builder: Fix handling of includedDependencies/excludedDependencies

    @matz3
    matz3 committed May 24, 2022
    Configuration menu
    Copy the full SHA
    bc0c0b7 View commit details
    Browse the repository at this point in the history

  4. ComponentProject: Ensure linking of resources that are not modified

    @matz3
    matz3 committed May 24, 2022
    Configuration menu
    Copy the full SHA
    b77d490 View commit details
    Browse the repository at this point in the history

  5. [INTERNAL] projectGraphBuilder: Throw if node has top-level configura… 

    …tion attributes

To help detect incorrect use of the new Project Graph APIs, an error is
thrown in case a provided node has top-level configuration properties
like 'specVersion' or 'metadata'. In the past these properties where
expected as part of a tree node. Now they need to go into a dedicated
'configuration' attribute.
    @RandomByte
    RandomByte committed May 24, 2022
    Configuration menu
    Copy the full SHA
    40cc284 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. ApplicationBuilder: Fix componentPreload excludes config

    @matz3
    matz3 committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a736acf View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. [INTERNAL] Library: Add tests from ui5-builder

    @RandomByte
    RandomByte committed May 26, 2022
    Configuration menu
    Copy the full SHA
    717d447 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. [INTERNAL] Library: Add missing test for getNamespaceFromManifest

    @RandomByte
    RandomByte committed May 27, 2022
    Configuration menu
    Copy the full SHA
    ecda5c1 View commit details
    Browse the repository at this point in the history

  2. [INTERNAL] Module: Add tests from ui5-builder

    @RandomByte
    RandomByte committed May 27, 2022
    Configuration menu
    Copy the full SHA
    f2f607f View commit details
    Browse the repository at this point in the history

  3. [INTERNAL] Application: Add missing tests for _configureAndValidatePaths

    @RandomByte
    RandomByte committed May 27, 2022
    Configuration menu
    Copy the full SHA
    46968e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. [INTERNAL] ComponentProject: Allow writing resources outside of names… 

    …pace
    @RandomByte
    RandomByte committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    6bae282 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. [INTERNAL] ProjectGraph: getAll* to return flat array

    @RandomByte
    RandomByte committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    bae6c21 View commit details
    Browse the repository at this point in the history

  2. NodePackageDependencies: Fix dependency resolution

    @matz3
    matz3 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    6433eaa View commit details
    Browse the repository at this point in the history

  3. [INTERNAL] builder: Adapt to ProjectGraph#getAllProjects flat array c… 

    …hange
    @RandomByte
    RandomByte committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    0ac1569 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. [INTERNAL] Projects: Pass builder resource excludes to adapters

    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    84abeb6 View commit details
    Browse the repository at this point in the history

  2. Rename archive metadata to build description 

    Restructure metadata file
    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    0eecee5 View commit details
    Browse the repository at this point in the history

  3. Module: Fix build descripton parameter naming

    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    96e5ae6 View commit details
    Browse the repository at this point in the history

  4. builder: Fix handling for projects with build description

    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    16a6d76 View commit details
    Browse the repository at this point in the history

  5. Adapt tests for refactored build description

    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    769d759 View commit details
    Browse the repository at this point in the history

  6. Module: Fix resources excludes configuration

    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    29100bd View commit details
    Browse the repository at this point in the history

  7. [INTERNAL] ui5Framework: Throw in case required dependencies of frame… 

    …work lib are missing from the graph
    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    0ed62d0 View commit details
    Browse the repository at this point in the history

  8. [INTERNAL] Cleanup specifications: Move project specifics into projec… 

    …t class
    @RandomByte
    RandomByte committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ec31cc4 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. [INTERNAL] Add basic migration of legacy spec versions

    @RandomByte
    RandomByte committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    3fc936b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Rename build description to build manifest

    @RandomByte
    RandomByte committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d2a61f3 View commit details
    Browse the repository at this point in the history

  2. generateProjectGraph: Allow rootConfiguration/rootConfigPath in all v… 

    …ariants
    @matz3
    matz3 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    b4f0594 View commit details
    Browse the repository at this point in the history

  3. Builder: Fix renaming of build manifest

    @RandomByte
    RandomByte committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    663099d View commit details
    Browse the repository at this point in the history

  4. graph.Module: Fix parameters handling

    @matz3
    matz3 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    0e8e56b View commit details
    Browse the repository at this point in the history

  5. Remove type legacy-library

    @RandomByte
    RandomByte committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    0317cd0 View commit details
    Browse the repository at this point in the history

  6. Stop passing legacy 'namespace' parameter to tasks

    @RandomByte
    RandomByte committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    073418c View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Only create build manifest for root project and only for libraries

    @RandomByte
    RandomByte committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    1064c93 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Remove projectContext.STANDARD_TAGS 

    They are exposed in TaskUtil already
    @RandomByte
    RandomByte committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    50d4137 View commit details
    Browse the repository at this point in the history

  2. Add missing tests

    @matz3
    matz3 committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    9503f21 View commit details
    Browse the repository at this point in the history

  3. Update log messages

    @RandomByte
    RandomByte committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    ba1927e View commit details
    Browse the repository at this point in the history

  4. Fix generateProjectGraph.usingObject test

    @matz3
    matz3 committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    6dfbb45 View commit details
    Browse the repository at this point in the history

  5. Implement migration of legacy projects

    @matz3
    matz3 committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    236585b View commit details
    Browse the repository at this point in the history

  6. Add error handling for failed spec version migration

    @RandomByte
    RandomByte committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    737aa24 View commit details
    Browse the repository at this point in the history