[FIX] Project#getReader: Do not apply builder resource excludes for style 'runtime' #574
+678
−362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyle 'runtime' Introduce new style 'dist' to reflect the standard build output structure which can be used with any HTTP server. It is identical to the 'runtime' style, but also applies any configured builder resource excludes[1]. ProjectBuilder now uses style 'dist' instead of 'runtime'. [1]: https://sap.github.io/ui5-tooling/stable/pages/Configuration/#exclude-resources Fixes SAP/ui5-tooling#779
matz3
approved these changes
Feb 14, 2023
|
@RandomByte Any ETA for releasing a new version with this change? 🚀 |
|
@Magoli1 Probably later today! |
RandomByte
added a commit
that referenced
this pull request
Feb 16, 2023
This resolves a regression caused by #574 where the application of builder resource-exclude configuration was moved from the low-level _getSourceReader/_getTestReader methods to the high-level getReader API. However, it was missed to also adapt the high-level getWorkspace API in the same manner. This caused the created workspace reader/writer to ignore any exclude configuration as reported in SAP/ui5-tooling#784 (comment)
RandomByte
added a commit
that referenced
this pull request
Feb 17, 2023
This resolves a regression caused by #574 where the application of builder resource-exclude configuration was moved from the low-level _getSourceReader/_getTestReader methods to the high-level getReader API. However, it was missed to also adapt the high-level getWorkspace API in the same manner. This caused the created workspace reader/writer to ignore any exclude configuration as reported in SAP/ui5-tooling#784 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new style
distto reflect the standard build outputstructure which can be used with any HTTP server. It is identical to the
runtimestyle, but also applies any configured builder resourceexcludes.
ProjectBuilder now uses style 'dist' instead of 'runtime'.
Fixes SAP/ui5-tooling#779