Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicPageTitle: A11y: Count of number of items in overflow popover not read by screen readers #5926

Closed
1 task done
abhijeet181088 opened this issue Jun 14, 2024 · 3 comments · Fixed by #6544 or #6545
Closed
1 task done
Assignees
Labels
a11y bug Something isn't working released

Comments

@abhijeet181088
Copy link

Describe the bug

If there are more number of buttons in the DynamicPageTitle -> actions, extra buttons are pushed to the menu popover.
On accessing this overflow button and opening the popover, the count of items in the popover is not read by JAWS and NVDA screen readers in Windows system.
This works fine with macOS in-built screen reader.

Isolated Example

https://stackblitz.com/edit/github-lg4jzd-ks2x4w?file=src%2FApp.tsx

Reproduction steps

  1. Go to the stackblitz example provided
  2. Turn on JAWS/NVDA screen reader
  3. Navigate to Overflow menu button in the DynamicPageTitle
  4. Activate the button to open the popover
  5. JAWS/NVDA does not read the count of items in the popover (screenshot attached)
  6. MacOS screeen-reader reads the count (screenshot attached)

Expected Behaviour

JAWS/NVDA should read the count of items in the overflow popover

Screenshots or Videos

Windows+Jaws_CountNotRead Mac_CountIsRead

UI5 Web Components for React Version

1.28.0

UI5 Web Components Version

1.24.0

Browser

Edge

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.29.13 🎉

The release is available on v1.29.13

Your semantic-release bot 📦🚀

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.3.2 🎉

The release is available on v2.3.2

Your semantic-release bot 📦🚀

@Lukas742
Copy link
Contributor

Hi @abhijeet181088

the Toolbar issue has been fixed in v1.29.13 and v2.3.2. In v1, the Toolbar is used internally by the DynamicPageTitle, so the fix is applied there as well.

To properly enable announcements, make sure to set the data-accessible-name prop on all components that implement accessibleName instead of aria-label. You can find more details here: https://sap.github.io/ui5-webcomponents-react/v1/?path=/docs/layouts-floorplans-toolbar--docs#announce-number-of-items-in-overflow-popover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y bug Something isn't working released
Projects
Status: 🆕 New
3 participants