Fix: cleanup when the prompt fails. (#947)

SBoudrias · Jul 23, 2020 · 833a4cd · 833a4cd
1 parent 96db664
commit 833a4cd
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/packages/inquirer/lib/prompts/base.js b/packages/inquirer/lib/prompts/base.js
@@ -56,8 +56,11 @@ class Prompt {
    */
 
   run() {
-    return new Promise((resolve) => {
-      this._run((value) => resolve(value));
+    return new Promise((resolve, reject) => {
+      this._run(
+        (value) => resolve(value),
+        (error) => reject(error)
+      );
     });
   }
 

diff --git a/packages/inquirer/lib/ui/prompt.js b/packages/inquirer/lib/ui/prompt.js
@@ -55,7 +55,7 @@ class PromptUI extends Base {
         }, this.answers)
       )
       .toPromise(Promise)
-      .then(this.onCompletion.bind(this));
+      .then(this.onCompletion.bind(this), this.onError.bind(this));
   }
 
   /**
@@ -68,6 +68,11 @@ class PromptUI extends Base {
     return this.answers;
   }
 
+  onError(error) {
+    this.close();
+    return Promise.reject(error);
+  }
+
   processQuestion(question) {
     question = _.clone(question);
     return defer(() => {

diff --git a/packages/inquirer/test/specs/inquirer.js b/packages/inquirer/test/specs/inquirer.js
@@ -54,6 +54,27 @@ describe('inquirer.prompt', function () {
     });
   });
 
+  it('should close readline instance on rejected promise', function (done) {
+    this.prompt.registerPrompt('stub', function () {
+      this.run = () => {
+        return Promise.reject(new Error('test error'));
+      };
+    });
+
+    var promise = this.prompt({
+      type: 'stub',
+      name: 'q1',
+    });
+
+    var rl1 = promise.ui.rl;
+
+    promise.catch(() => {
+      expect(rl1.close.called).to.equal(true);
+      expect(rl1.output.end.called).to.equal(true);
+      done();
+    });
+  });
+
   it('should take a prompts array and return answers', function () {
     var prompts = [
       {