#2569 Fixed deleting non existent user profile #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Patrykb0802
commented
Jun 19, 2023
Patrykb0802
commented
- Added condition for showing delete button in showUserProfile function in UserProfiles.jsp
- Deprecated show($("deleteButton")); that forced showing delete button no matter what.
- Added show("deleteButton"); to saveUserProfile function to show deletebutton for freshly made user profiles
- Added condition for showing delete button in showUserProfile function in UserProfiles.jsp
- Deprecated show($("deleteButton")); that forced showing delete button no matter what.
- Added show("deleteButton"); to saveUserProfile function to show deletebutton for freshly made user profiles
Limraj
reviewed
Jun 19, 2023
| @@ -133,6 +133,10 @@ | |||
| } | |||
|
|
|||
| function showUserProfile(userProfileId) { | |||
| if (userProfileId == -1) | |||
There was a problem hiding this comment.
- Click on 'Add user profile';
- Empty 'Profile name';
- Click on 'save'; -> Message appears 'Profile name must be unique and not empty'
- "Delete" button appears;
- Click on "Delete" button -> "Are you sure you want to delete this profil?" ok -> "Profile successfully deleted." ok -> "Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'." error
- Added condition for showing delete button in showUserProfile function in UserProfiles.jsp
- Deprecated show($("deleteButton")); that forced showing delete button no matter what.
- Added show("deleteButton"); to saveUserProfileCB function to show deletebutton for freshly made user profiles
Limraj
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.