Feature/#2384 added test script in meta data source on new UI #2687

Limraj · 2023-09-05T06:56:03Z

No description provided.

In point.vue: - Added validateScript() method - Added 'Run script' button to Meta Data Point editing - Added alert that shows result of working script - Modified script textarea to run validateScript method - Added new rule that is checking if script is correct - Added script.runScript translation key to en.json

- Added correct error message when creating new data point and script field is empty - Added delayed validation, so requests for validation are not send every letter typed - Added handling of error when field for script is empty and you press "run script", now when field is empty and you press "run script" nothing happens - Deleted duplicated property key dox.newUISettings

This reverts commit 032e8e1.

This reverts commit 23d8dbf.

- Added validation in validateScript() method for empty text area of script - Added script validation when focusing out of the script text area - Added script validation when changing data point type so there is no possibility of saving with incorrect script

…Meta_Data_Source_on_new_UI

corrected en.json

- Added validation after adding context datapoint for script - Added validation after editing text fields like data point name, datapoint export ID and description

- Moved error messages to alert component - Added valdiation on removing context datapoint

- Removed validation on focus out for textareas: Data point name, export ID, description

Limraj

Problem 1

Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page and edit dp_1;
Added disabled Data Point to Script Context -> This does not trigger validation;
Expected behavior:
Also, a change in the context of the script should validate the script.

Problem 2

Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1;
Click on 'Run script' and add disabled Data Point to context, and click update -> Successfully updated script failing validation, as you can see by clicking in the Script field and then outside this field;

Problem 3

Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1;
Click on 'Run script' and add disabled Data Point to context, and click update;
Refresh page and edit dp_1;
Click on 'Run script' -> no message with the result of the script

Problem 4

Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1 -> The update button is not active, we change the description and it is still greyed out;

Expected behavior:
After changing fields such as description, or other field, the update button should be active;

Problem 5

Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1 -> The update button is not active, is greyed -> error

Expected behavior:
As in other forms, the update button should be available after opening the point edit form

Problem 6

Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Click on 'Cancel' -> The form window does not close and validates the script;

Expected behavior:
Clicking the cancel button should reset the form values and close the form window.

Actual result:

Problem 2-4 -> ok;
Problem 1 -> Changing script context, triggers validation -> ok;
Problem 5 -> Right after opening the form create and edit, it unnecessarily performs validation -> to correct;
Problem 6 -> Clicking cancel does not trigger the validation again and closes the form window -> ok;

github-actions · 2023-09-05T07:09:41Z

Java Script Mocha Unit Test Results

268 tests ±0 268 ✔️ ±0 5s ⏱️ -1s
  70 suites ±0     0 💤 ±0
    1 files ±0     0 ❌ ±0

Results for commit ee7c8c3. ± Comparison against base commit f16b925.

♻️ This comment has been updated with latest results.

github-actions · 2023-09-05T07:10:53Z

Java JUnit Test Results

2 097 tests +14 2 097 ✔️ +14 36s ⏱️ +11s
    90 suites ±  0       0 💤 ±  0
    90 files ±  0       0 ❌ ±  0

Results for commit ee7c8c3. ± Comparison against base commit f16b925.

♻️ This comment has been updated with latest results.

Limraj · 2023-09-05T12:12:06Z

scadalts-ui/src/components/datasources/MetaDataSource/point.vue

@@ -373,6 +389,7 @@ export default {
 		DataPointCreation,
 	},
 	async mounted() {
+    this.validateScript();


It needs to be leveled

Limraj · 2023-09-05T12:13:36Z

scadalts-ui/src/components/datasources/MetaDataSource/point.vue

+              <v-alert title = "Script error" type="error">
+                Script error: {{this.resultMessage}}
+              </v-alert>
+            </v-div>


Improve the structure so that it is clear where a given tag begins and ends.

- Added rules validation on load for data point creation form

Limraj

Problem 7

Click on 'Create new data point' for Meta Data Source;
Created Data Points with script "return 1;" as dp_1, and script "return 2;" as dp_2, disabled;
Refresh page, and edit Data Point dp_1;
Added disabled dp_2 to context -> validation stop, inactive update button -> ok
Click on 'Cancel' and edit -> You can update a Meta Data Point even though the context is disabled -> error

Problem 8

Click on 'Create new data point' for Meta Data Source;
Created Data Points with script "return 1;" as dp_1, and script "return 2;" as dp_2, disabled;
Refresh page, and edit Data Point dp_1;
Change script on "return p1.value;" and click active update button -> error

Expected behavior:
After clicking update/create before the request, it has to perform additional validation.

This reverts commit f448052.

This reverts commit 6b415b3.

This reverts commit 787144a.

This reverts commit 55f59cb.

Limraj · 2023-09-07T12:10:58Z

All listed problems have been fixed.

Patrykb0802 and others added 11 commits July 20, 2023 15:59

#2384 Added test script in Meta Data Source on new UI

032e8e1

Revert "#2384 Added test script in Meta Data Source on new UI"

0c91460

This reverts commit 032e8e1.

Revert "#2384 Added test script in Meta Data Source on new UI"

ca049d2

This reverts commit 23d8dbf.

Merge branch 'release/2.7.6' into feature/#2384_Added_test_script_in_…

5086fe9

…Meta_Data_Source_on_new_UI

Update en.json

6372fd7

corrected en.json

#2384 added test script in meta data source on new UI

4f82ade

- Added validation after adding context datapoint for script - Added validation after editing text fields like data point name, datapoint export ID and description

#2384 added test script in meta data source on new UI

cbf3d54

- Moved error messages to alert component - Added valdiation on removing context datapoint

#2384 added test script in meta data source on new UI

b296077

- Removed validation on focus out for textareas: Data point name, export ID, description

Limraj added this to the 2.7.7 milestone Sep 5, 2023

Limraj commented Sep 5, 2023

View reviewed changes

- Removed unnecessary script validation

6b415b3

- Added rules validation on load for data point creation form

Limraj commented Sep 5, 2023

View reviewed changes

Patrykb0802 added 11 commits September 6, 2023 15:58

Repaired formatting

f448052

Revert "Repaired formatting"

9f2fc03

This reverts commit f448052.

Revert "- Removed unnecessary script validation"

3df9a43

This reverts commit 6b415b3.

latest version

b7917f2

- Added validation on Update/Create button

787144a

Revert "- Added validation on Update/Create button"

5caf293

This reverts commit 787144a.

- Added validation on Update/Create button

55f59cb

Revert "- Added validation on Update/Create button"

2ed265f

This reverts commit 55f59cb.

- Added validation on Update/Create button

7cb4ad9

- Formatting repairment

5f42350

- Code formatting repair

ee7c8c3

Limraj mentioned this pull request Sep 21, 2023

Fix/#2607 fixed hide unnamed watchlist in form profile user for other lang #2695

Closed

Limraj closed this Oct 25, 2023

Limraj removed this from the 2.7.7 milestone Jan 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/#2384 added test script in meta data source on new UI #2687

Feature/#2384 added test script in meta data source on new UI #2687

Limraj commented Sep 5, 2023

Limraj left a comment •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

Limraj Sep 5, 2023

Limraj Sep 5, 2023

Limraj left a comment •

edited

Loading

Limraj commented Sep 7, 2023

Feature/#2384 added test script in meta data source on new UI #2687

Feature/#2384 added test script in meta data source on new UI #2687

Conversation

Limraj commented Sep 5, 2023

Limraj left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2023 • edited Loading

Java Script Mocha Unit Test Results

github-actions bot commented Sep 5, 2023 • edited Loading

Java JUnit Test Results

Limraj Sep 5, 2023

Choose a reason for hiding this comment

Limraj Sep 5, 2023

Choose a reason for hiding this comment

Limraj left a comment • edited Loading

Choose a reason for hiding this comment

Limraj commented Sep 7, 2023

Limraj left a comment •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

Limraj left a comment •

edited

Loading