Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nasm test #4607

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix nasm test #4607

merged 1 commit into from
Oct 12, 2024

Conversation

mwichmann
Copy link
Collaborator

Fix reported problem of missing header (no declaration for exit()). Clean up to current styles.

Test-only change.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Oct 5, 2024
@bdbaddog
Copy link
Contributor

bdbaddog commented Oct 5, 2024

Can you add a release.txt blurb and callout that it was fixed for issue found by debian packager?

@mwichmann
Copy link
Collaborator Author

didn't seem useful for release, no user will ever see that

@bdbaddog
Copy link
Contributor

bdbaddog commented Oct 6, 2024

didn't seem useful for release, no user will ever see that

This is a fix for the debian packager, so he'll see it..

Fix reported problem of missing header (no declaration for exit()).
Clean up to current styles.

Signed-off-by: Mats Wichmann <mats@linux.com>
@mwichmann
Copy link
Collaborator Author

didn't seem useful for release, no user will ever see that

This is a fix for the debian packager, so he'll see it..

Pushed

@bdbaddog bdbaddog merged commit cbb75dc into SCons:master Oct 12, 2024
6 of 7 checks passed
@mwichmann mwichmann added this to the NextRelease milestone Oct 13, 2024
@mwichmann mwichmann deleted the test/nasm-fix branch October 13, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants