Fix RSBot.Trade load settings #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how the view RSBot.Trade is loading default values.
BREAKING CHANGE: Disable selecting any tab with property enable = False
The tabs disabled are these plugins with the property RequireIngame = True
The hotfix for the interface requires this line in the main view:
tabMain.Selecting += tabMain_Selecting;
If a tab with the property "RequireIngame = True" is loaded before the bot can get the information required from the game, its interface won't work rightly.
It's a hotfix, but a long-term solution it's yet to be found.