Make isSVGFormatForData work for small SVG strings #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `isSVGFormatForData` breaks when the SVG is less than 100 characters, which should be permitted (e.g., "`<svg><circle/></svg>`" is valid SVG).
|
This may block the caller queue, if your search SVG contents file size larger than 1MB. Because |
|
If you want to change, maybe we need to change the same logic in |
|
Merge for now. For SDWebImage Core repo, I'll submit another PR. |
|
Release v1.5.2 |
Merged
8 tasks
|
I don't see how it blocks any more than the previous code did … both of them are only checking the last 100 bytes of the NSData for the closing "" tag. The fix simply also permits checking in SVG data that is itself less than 100 bytes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
isSVGFormatForDatabreaks when the SVG is less than 100 characters, which should be permitted (e.g., "<svg><circle/></svg>" is valid SVG).