Update what's new

SDXorg · Jul 17, 2024 · 0ea2db3 · 0ea2db3
1 parent c305f76
commit 0ea2db3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 18 deletions.
diff --git a/docs/whats_new.rst b/docs/whats_new.rst
@@ -1,6 +1,6 @@
 What's New
 ==========
-v3.14.1 (2024/07/XX)
+v3.14.1 (2024/07/18)
 --------------------
 New Features
 ~~~~~~~~~~~~
@@ -15,8 +15,11 @@ Bug fixes
 ~~~~~~~~~
 - Support for :py:mod:`numpy` 2. (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
 - Allow multiple font styles in var names (:issue:`443`). (`@rogersamso <https://github.com/rogersamso>`_)
-- Allow Vensims GET DIRECT/XLS SUBSCRIPT when lastcell is not a cell value  (:issue:`443`). (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
-- Allow Vensims GET DIRECT/XLS SUBSCRIPT defined with cell range names  (:issue:`261`). (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Allow Vensims GET DIRECT/XLS SUBSCRIPT when lastcell is not a cell value (:issue:`443`). (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Allow Vensims GET DIRECT/XLS SUBSCRIPT defined with cell range names (:issue:`261`). (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Translate filenames as raw :py:class:`str` to made them work properly for Windows paths (:issue:`443`). (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Improve support for reading :py:class:`pysd.py_backend.external.External` from all the spreadsheet files includying those types from open software ('.odf', '.ods', '.odt'). (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Improve support for reading :py:class:`pysd.py_backend.external.External` from CSV, TAB and any other kind of text file. (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
 
 Documentation
 ~~~~~~~~~~~~~
@@ -28,6 +31,10 @@ Internal Changes
 ~~~~~~~~~~~~~~~~
 - Fix CI tests. (`@rogersamso <https://github.com/rogersamso>`_)
 - Run CI coverage only on ubuntu and lowest Python. (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Rename 'sheet' by 'tab' in :py:class:`pysd.py_backend.external.External` and related functions and classes to follow Vensim's nomenclature. (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Add error message when no subscripts are read from :py:class:`pysd.py_backend.external.ExtSubscript` during the model building. (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Add error message when a :py:class:`pysd.py_backend.external.External` cell/firstcell is interpreted as cellrange name but the input file is not a spreadsheet. (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
+- Improve parsing of quoted arguments in the vensim translator for external lookups and external subscripts. (`@enekomartinmartinez <https://github.com/enekomartinmartinez>`_)
 
 v3.14.0 (2024/04/24)
 --------------------

diff --git a/tests/pytest_types/external/pytest_external.py b/tests/pytest_types/external/pytest_external.py
@@ -3724,21 +3724,6 @@ def test_subscript_name_in_csv(self, _root):
                                        prefix=prefix)
 
 
-    # TODO
-    def test_empty_subscript_range(self, _root):
-        """
-        Test for an empty subscript range
-        """
-        import pysd
-
-        file_name = "data/input.csv"
-        sheet = ""
-        firstcell = "A5"
-        lastcell = "5"
-        prefix = "sr"
-
-
-
 class DownwardCompatibility():
     """
     These tests are defined to make the external objects compatible