Add property measure class method defaults #4778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
PropertyMeasure
s are imported via an AT submission sync. ThePropertyMeasure
model has 3 choice fields (category_affected
,implementation_status
, andapplication_scale
), each with a default choice.Modify the
PropertyMeasure
model's class methods to handle edge cases where integer choice fields returned None. Previously, the integer fields did not allow null values, and default choices were only applied when the field was entirely omitted, not whenNone
was returned for edge cases.The Berkeley data error was related to a single submission (Custom ID 1: 3100). One of the first measures brought in had an unrecognized
category_affected
("OnSite..." vs "On-Site...") leading to aNone
value being assigned and triggered a non-null constraint. This caused the loop to exit early and prevented any other property updates.What's this PR do?
PropertyMeasure
class methods to return defaults instead ofNone
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)