Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup shebangs #4799

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Cleanup shebangs #4799

merged 2 commits into from
Sep 17, 2024

Conversation

axelstudios
Copy link
Member

@axelstudios axelstudios commented Sep 17, 2024

Any background context you want to provide?

Shebangs (#!) should only be on executable python files that are meant to be run directly, and we only have two such files (manage.py and celery.py)

What's this PR do?

  • Removes unnecessary shebangs, and adds a Ruff rule to enforce this
  • Removes python 2 basestring usage
  • Removes the deprecated, unused check_compressed.py script
  • Adds missing copyrights
  • Fixes incorrect shebangs
  • Fixes bug with guillemet Unicode normalization
  • Fixes 4 broken copyright URLs

How should this be manually tested?

Tests should pass

@axelstudios axelstudios added Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label. Bug labels Sep 17, 2024
- Removed python 2 basestring
- Added missing copyrights
- Fixed incorrect shebangs
- Fixed bug with guillemet Unicode normalization
Comment on lines -56 to -57
ord("‹"): """, # noqa: RUF001
ord('›'): """, # noqa: RUF001
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was bad 😬

Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kflemin kflemin merged commit 26bdf55 into develop Sep 17, 2024
9 checks passed
@kflemin kflemin deleted the task/cleanup-shebang branch September 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants