Skip to content

Commit

Permalink
intel_idle: Remove superfluous SMP fuction call
Browse files Browse the repository at this point in the history
Since commit 1cf4f62 ("cpu/hotplug: Move online calls to
hotplugged cpu") the CPU_ONLINE and CPU_DOWN_PREPARE notifiers are
always run on the hot plugged CPU, and as of commit 3b9d6da
("cpu/hotplug: Fix rollback during error-out in __cpu_disable()") the
CPU_DOWN_FAILED notifier also runs on the hot plugged CPU. This patch
converts the SMP functional calls into direct calls.

smp_function_call_single() executes the function with interrupts
disabled. This calling convention is not preserved, because
tick_broadcast_enable() and tick_braodcast_disable() handle
interrupts themselves.

Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
anna-marialx authored and rafaeljw committed Dec 1, 2016
1 parent 4e28ec3 commit 29d7bba
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/idle/intel_idle.c
Original file line number Diff line number Diff line change
Expand Up @@ -971,8 +971,7 @@ static int cpu_hotplug_notify(struct notifier_block *n,
case CPU_ONLINE:

if (lapic_timer_reliable_states != LAPIC_TIMER_ALWAYS_RELIABLE)
smp_call_function_single(hotcpu, __setup_broadcast_timer,
(void *)true, 1);
__setup_broadcast_timer((void *)true);

/*
* Some systems can hotplug a cpu at runtime after
Expand Down

0 comments on commit 29d7bba

Please sign in to comment.