CumulusCI.yml linter based on Pydantic #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 3, 2020 10:49
TheBitShepherd
previously approved these changes
Sep 15, 2020
There was a problem hiding this comment.
This looks good to me. Thanks for letting me walk myself through the code with you @prescod!
prescod
force-pushed
the
feature/cci_yml_parser
branch
from
45a3851
to
d4175ae
Compare
|
@prescod A big part of why I let this one stall out is because I'm nervous about breaking things because there is something used in the wild that we missed including in the validator. Could we start with this in a mode that is either opt-in or logs warnings rather than aborting, so that we have a way to try it out and find the gaps? |
|
If my time machine is properly functioning then that's how it already works. :) It returns the data along with printing warnings about problems. This iteration of it does not block people from using incorrect CCI.yml files. The Pydantic model is used entirely in an advisory way. |
added 5 commits
February 18, 2021 20:41
prescod
changed the title
davisagli
suggested changes
Apr 1, 2021
Co-authored-by: David Glick <dglick@salesforce.com>
davidmreed
reviewed
Apr 2, 2021
davisagli
reviewed
Apr 7, 2021
davisagli
previously approved these changes
Apr 8, 2021
davisagli
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates CumulusCI.yml files now. If they do not match the pattern, it will generate a warning.
Incorporates the NBSP cleanup tool from the other branch.