Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openage gamestate fixes #106

Merged
merged 9 commits into from
Jul 2, 2023
Merged

openage gamestate fixes #106

merged 9 commits into from
Jul 2, 2023

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Jun 13, 2023 •
edited
Loading

Companion PR for SFTtech/openage#1515

  • Requires bump to version 0.3.0 because of the API changes.

@heinezen
db: Fix dangling reference when returning member value.
3dfcefc 
This happened because the member value is copied for the calculation of inherited member operations/assignments.
@heinezen heinezen marked this pull request as draft June 13, 2023 16:47
@heinezen heinezen mentioned this pull request Jun 27, 2023
Closed
@TheJJ TheJJ marked this pull request as ready for review July 2, 2023 16:34
@TheJJ TheJJ merged commit 35a50b0 into SFTtech:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinezen @TheJJ