Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nyan_specification.md #97

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Update nyan_specification.md #97

merged 1 commit into from
Apr 6, 2022

Conversation

apainintheneck
Copy link
Contributor

A few grammar and spelling updates to improve readability.

TheJJ
TheJJ previously approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes! :)

(the iff is actually math-notation, but we should rather write "when" there to make it more clear)

@TheJJ TheJJ added documentation involves primarily the code docs bugfix restores intended behavior labels Apr 5, 2022
@TheJJ
Copy link
Member

TheJJ commented Apr 5, 2022

If you want, you can update the iff-when thing, otherwise I'll go ahead and merge!

@apainintheneck
Copy link
Contributor Author

apainintheneck commented Apr 5, 2022 •
edited
Loading

Ah, that totally went over my head. Yeah, I think when would be more intuitive there (at least for me). It's been updated now.

@apainintheneck
Update nyan_specification.md
69f1592 
A few grammar and spelling updates to improve readability.
TheJJ
TheJJ approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@TheJJ TheJJ merged commit 3ba9394 into SFTtech:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
bugfix restores intended behavior documentation involves primarily the code docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apainintheneck @TheJJ