Correctly detect presence of keyword parameters #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`n_args` doesn't count keyword (named) parameters, and it's possible to pass in only some of those, so we need something else than `n_args > x` to check whether a given keyword parameter is present. `MP_OBJ_IS_TYPE(MP_OBJ_NULL, &whatever)` will crash, but `MP_OBJ_IS_TYPE(mp_const_none, &whatever)` will always return 'false', so the latter is a more suitable default for non-required keyword parameters. See also caaf6ab
|
(reviewed by @aczid) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n_argsdoesn't count keyword (named) parameters, and it's possible to pass inonly some of those, so we need something else than
n_args > xto checkwhether a given keyword parameter is present.
MP_OBJ_IS_TYPE(MP_OBJ_NULL, &whatever)will crash, butMP_OBJ_IS_TYPE(mp_const_none, &whatever)will always return 'false', so thelatter is a more suitable default for non-required keyword parameters.
See also caaf6ab