Made the demo thingy properly center text. #7
Conversation
… a bit to the right to allow for longer names.
|
Oh, and I also added some ifndefs because the simulator won't compile with the input stuff right now. |
|
Depends on SHA2017-badge/Firmware#23 |
We also lose ugfx.print_funts() which was somehow broken. See micropython#23
|
Note, commit message refers not to #23 in here, but SHA2017-badge/Firmware#23 (review) :) |
|
|
||
| gdispClear(White); | ||
| gdispDrawString(150, 25, "STILL", robotoBlackItalic, Black); | ||
| gdispDrawString(130, 50, mp_obj_str_get_str(hacking), permanentMarker, Black); | ||
| gdispDrawStringBox(0, 6, 296, 40, "STILL", robotoBlackItalic, Black, justifyCenter); |
| @@ -655,8 +638,6 @@ STATIC const mp_rom_map_elem_t ugfx_module_globals_table[] = { | |||
| {MP_OBJ_NEW_QSTR(MP_QSTR_polygon), (mp_obj_t)&ugfx_polygon_obj}, | |||
| {MP_OBJ_NEW_QSTR(MP_QSTR_fill_polygon), (mp_obj_t)&ugfx_fill_polygon_obj}, | |||
|
|
|||
| {MP_OBJ_NEW_QSTR(MP_QSTR_print_fonts), (mp_obj_t)&ugfx_print_fonts_obj}, | |||
There was a problem hiding this comment.
are we implementing some API here or do we decide for ourselves what needs to be exposed?
in any case the current implementation is ugly so removing the function altogether seems like an improvement to me, would appreciate a second set of eyes :)
| @@ -0,0 +1 @@ | |||
| ../../components/ugfx/PermanentMarker36.c | |||
There was a problem hiding this comment.
hmm it'd be nice to avoid this but it's consistent with how we handle other fonts ;)
There was a problem hiding this comment.
I did this only because that's how the others were setup. It seems to just work when I remove the symlinks and just move the fonts from components/ugfx/ to micropython/esp32/. I could commit that to both PR's if desired.
There was a problem hiding this comment.
No please don't move them, then it won't work with pure ugfx (without python) anymore :).
it'd be nice if upy could use the ugfx fonts without these symlinks, but that might be hard for some reason. Anyway this is OK for now.
|
Actually let's just go for it, can always add something later ;) |
Also moved all of the text a bit to the right to allow for longer names.
http://imgur.com/a/UCyBV :)