Lots of stuff: a bugfix in the service routine, moar settings and a c… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouple of small other things
raboof
reviewed
Jul 17, 2017
| @@ -2,8 +2,15 @@ | |||
|
|
|||
| def start_app(app): | |||
| ugfx.clear(ugfx.WHITE) | |||
| ugfx.string(0, 0, "Starting "+app+"...","Roboto_Regular12",ugfx.BLACK) | |||
| ugfx.string(0, 0, "Please wait...", "PermanentMarker22", ugfx.BLACK) | |||
| if (app==""): | |||
There was a problem hiding this comment.
could be just if app:, then it also works for None
raboof
reviewed
Jul 17, 2017
| ugfx.string(0, 0, "Starting "+app+"...","Roboto_Regular12",ugfx.BLACK) | ||
| ugfx.string(0, 0, "Please wait...", "PermanentMarker22", ugfx.BLACK) | ||
| if (app==""): | ||
| ugfx.string(0, 25, "Returning to homescreen...","Roboto_Regular12",ugfx.BLACK) |
There was a problem hiding this comment.
as we expect the homescreen to work I'd be OK with skipping this intermediate text+flush and just rebooting immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ouple of small other things