Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esp-idf vfs #75

Merged
merged 20 commits into from
Jul 21, 2017
Merged

Use esp-idf vfs #75

merged 20 commits into from
Jul 21, 2017

Conversation

annejan
Copy link
Member

@annejan annejan commented Jul 18, 2017

This branch by @rnplus seems like a good way to bolt the esp-idf vfs under micropython in stead of its default vfs.

@Spritetm
Copy link

Erm... all the code in there is dummy'ed out, is that intentional?

@annejan
Copy link
Member Author

annejan commented Jul 19, 2017

Sorry for lack of intro from irc .. this is not yet ready code
Just a start . .
So yes, it seems it is intentional 😉

@annejan annejan mentioned this pull request Jul 19, 2017
Copy link

@basvs basvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing my own code…

mount(), umount() and mkfs() are not supported (although mount() is used as trigger to mount the filesystem on /) → this is all intentional

open() is a bit verbose when the open fails.
we might want to lower this one day..

@basvs
Copy link

basvs commented Jul 19, 2017

previous comments mentioned stubs. there shouldn't be any stubs anymore.

@annejan annejan merged commit db4a8ce into master Jul 21, 2017
@basvs basvs deleted the espvfs branch July 21, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants