Make using dependencies branch toggleable #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update name for this input in workflow for updating pyproject.toml to be `target_branch`, deprecating `permanent_dependencies_branch`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 12 12
Lines 900 900
=======================================
Hits 730 730
Misses 170 170 ☔ View full report in Codecov by Sentry. |
This reverts commit ecff44c.
|
The new warning message has been tested (see this run) and looks to work as intended. |
CasperWA
requested review from
francescalb and
sygout
and removed request for
francescalb
Handle all the different cases between the now deprecated 'permanent_dependencies_branch' input value and the replacement 'target_branch' value with more appropriate warning messages and results.
CasperWA
requested review from
daniel-sintef
and removed request for
ajeklund
daniel-sintef
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update name for this input in workflow for updating pyproject.toml to be
target_branch, deprecatingpermanent_dependencies_branch.Closes #183
This will make it easier for users to choose or indeed not choose to update dependencies in this way.