Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set python 3.10 in ci_tests and cd_docs in gitub workflows. #874

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

francescalb
Copy link
Collaborator

Description

Also changed ubuntu to ubuntu-latest in ci-tests

In the ci_tests workflow, all dependencies are installed (also those of docs).
The docs dependencies are for a specific version and are not a range of versions,
hence they fail if the required version does not support older python-versions.

Python3.10 set as standard for this reason.

Description

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Also changed ubuntu to ubuntu-latest in ci-tests
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks that we have to add numpy<2.0.0 to requirements.txt

@francescalb francescalb merged commit 3ce8434 into master Jul 4, 2024
15 checks passed
@francescalb francescalb deleted the py3.10_for_ci_tests_docs branch July 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants