Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory debugging #896

Merged
merged 10 commits into from
Aug 9, 2024
Merged

Memory debugging #896

merged 10 commits into from
Aug 9, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Jul 13, 2024

Description

Added documentation of how to do memory debugging with DLite.

Also:

  • Allow to pass arguments to make memcheck (via the environment)
  • Documented use of DLITE_PYDEBUG for debugging Python storage plugins
  • Moved supression of memory leak in pydantic to cmake/valgrind-python.supp

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

- Fixed leak in json_memload()
- Fixed leak in global session when running with DLITE_ATEXIT_FREE set
- Added a FIXME for a leak in mapping_create_rec() in src/dlite-mappings.c
- Set DLITE_ATEXIT_FREE when running `make memcheck`
- Ignore external leaks in pydantic and numpy random_bit_generator
@jesper-friis jesper-friis changed the base branch from master to fix-memory-leaks July 13, 2024 19:31
@jesper-friis jesper-friis changed the base branch from fix-memory-leaks to master July 13, 2024 19:32
@jesper-friis jesper-friis changed the base branch from master to fix-memory-leaks July 13, 2024 19:36
Base automatically changed from fix-memory-leaks to master August 8, 2024 07:57
@jesper-friis jesper-friis merged commit aa0207c into master Aug 9, 2024
15 checks passed
@jesper-friis jesper-friis deleted the memory-debugging branch August 9, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants