-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation of how to handle code changes. #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial suggestion that should be reviewed.
torhaugl
reviewed
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
9 tasks
jesper-friis
added a commit
that referenced
this pull request
Aug 16, 2024
Implemented the formalised code changes described in PR #920. **Benefits**: Make it possible to improve our control over code changes. Provide predictability for when changes will happen and give users a time-span to a given versions number to adapt to new changes. * Improved deprecation warnings and initial implementation of behavior. * Added a simple Python class for accessing behavior from Python * Added Python interface to behaviours. * Added initialisation of behavior table and simplified the logics. * Fixed a bug in natoi() * Fix documentation strings. * Documented environment variables DLITE_BEHAVIOR_* * Added more instructions to warning in dlite_behavior_get() --------- Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an initial suggestion that should be reviewed.
When agreed, the suggested API should be implemented.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.