-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
137 setuptools is not installing requirements properly #138
Merged
emlynjdavies
merged 33 commits into
129-make-high-level-admin-cmd-line-entry-points
from
137-setuptools-is-not-installing-requirements-properly
Sep 25, 2023
Merged
137 setuptools is not installing requirements properly #138
emlynjdavies
merged 33 commits into
129-make-high-level-admin-cmd-line-entry-points
from
137-setuptools-is-not-installing-requirements-properly
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlynjdavies
changed the base branch from
main
to
129-make-high-level-admin-cmd-line-entry-points
September 21, 2023 18:55
…37-setuptools-is-not-installing-requirements-properly
emlynjdavies
added
patch / enhancement
improved functionality or patch indented for changes that require bumping only the PATCH number
dependencies
Pull requests that update a dependency file
labels
Sep 23, 2023
Closed
odaom
reviewed
Sep 25, 2023
odaom
reviewed
Sep 25, 2023
odaom
reviewed
Sep 25, 2023
emlynjdavies
merged commit Sep 25, 2023
5a4fc50
into
129-make-high-level-admin-cmd-line-entry-points
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
patch / enhancement
improved functionality or patch indented for changes that require bumping only the PATCH number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to merge into #129
A switch to poetry-managed dependencies and install, instead of setuptools and requirements.txt: https://mathdatasimplified.com/2023/06/12/poetry-a-better-way-to-manage-python-dependencies/
Note:
Tensorflow doesn't work properly on the gihub windows test when installing with poetry (despite working locally on a windows machine). It does work on github when installing with pip, so I think putting a ubuntu test using poetry and a windows test using pip is satisfactory for now. This way we can test pyopia functionality in both windows and linux.
A check that a pip install of pyopia from github uses the correct pyopia version number:
pip install git+https://github.com/SINTEF/pyopia.git@137-setuptools-is-not-installing-requirements-properly
Gives expected version, and means there is backwards compatibility for the 'user install'.
Updates to developer install
Developer install should be done using:
(instead of the old
python setup.py develop
)and dependencies added using
poetry add
. It is encouraged to commit thepoetry.lock
file if you change or update dependencies.Tests can be run locally using:
(instead of the old
python setup.py test