Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for OS X #16

Open
ydinari opened this issue Jun 16, 2016 · 7 comments
Open

Support for OS X #16

ydinari opened this issue Jun 16, 2016 · 7 comments

Comments

@ydinari
Copy link

ydinari commented Jun 16, 2016

Need to change use of select.epoll (in launch.py) with select.select() (I think), because epoll is only supported on linux.
@goodboy
Copy link
Member

goodboy commented Jun 17, 2016

I can think of two ways:

  • use select.select.
  • detect BSD at import time and use a select.kqueue

I tried the former but it won't really work for detecting SIPp process completion since each subproc writes extensively to stderr/stdout, plus, I don't think we'll be able to do async launching the same way since you can't pre-register fds.

I have no experience with the latter and don't have a BSD machine to test on.

@vodik got any other ideas?
@ydinari If you'd like to take a try at using the latter that would be handy for sure :)

@goodboy
Copy link
Member

goodboy commented Jun 17, 2016 •
edited
Loading

Just a thought - after we bring in the py3 support (#15) we could just use asyncio?

@vodik
Copy link
Member

vodik commented Jun 17, 2016

@tgoodlet I have no problem with that so long as you're cool being python3 only.

@vodik
Copy link
Member

vodik commented Jun 17, 2016

@tgoodlet Oh, without asyncio, just use select.select, its going to work just fine.

goodboy pushed a commit that referenced this issue Jun 17, 2016
Use a plain old select loop
5e30bb3 
Use `select.select` to track subproc completion since `select.epoll`
isn't available on OSX.

Resolves #16
@goodboy
Copy link
Member

goodboy commented Jun 17, 2016

@ydinari Can you give #17 a try and let me know if it works for you?
Thanks!

@goodboy
Copy link
Member

goodboy commented Jul 21, 2016

@ydinari any luck trying that branch?

@goodboy
Copy link
Member

goodboy commented Aug 2, 2016

Earth to @ydinari?

goodboy pushed a commit that referenced this issue Dec 4, 2017
Use a plain old select loop
d08c1f7 
Use `select.select` to track subproc completion since `select.epoll`
isn't available on OSX.

Resolves #16
@goodboy goodboy mentioned this issue Aug 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vodik @goodboy @ydinari