Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxyaddr fix #46

Merged
merged 4 commits into from
Jul 4, 2019
Merged

Proxyaddr fix #46

merged 4 commits into from
Jul 4, 2019

Conversation

goodboy
Copy link
Member

@goodboy goodboy commented Oct 12, 2018

Redo of #35.
Fixes #36 and hopefully #39.

@y-luis @access2praveen mind having a quick look / trying this out.

@y-luis-rojo
Copy link
Contributor

@tgoodlet, tested OK from my side 👍

@goodboy
Copy link
Member Author

goodboy commented Oct 12, 2018

Huh, interesting pypy failures. I'll have to check that out manually.

@luismartingil
Copy link

@goodboy Can we maybe use pluggy-0.11.0? Looks like it does the trick (python 2.7):

platform linux2 -- Python 2.7.5, pytest-4.5.0, py-1.8.0, pluggy-0.11.0
rootdir: /Volumes/data/pysipp
collected 55 items

tests/test_agent.py ...........                                                                                                                                                                              [ 20%]
tests/test_commands.py .....                                                                                                                                                                                 [ 29%]
tests/test_launcher.py ..                                                                                                                                                                                    [ 32%]
tests/test_loader.py ..                                                                                                                                                                                      [ 36%]
tests/test_stack.py ...................................

@goodboy
Copy link
Member Author

goodboy commented May 27, 2019

Huh very good point @luismartingil.
Just pushed a commit to use latest pluggy.

@goodboy
Copy link
Member Author

goodboy commented May 27, 2019

Hmm seems to still be failing @luismartingil even with pluggy==0.11.0. I don't have pypy set up locally atm. Did you actually test with the version that's running on travis?

@goodboy goodboy mentioned this pull request Jul 4, 2019
Tyler Goodlet and others added 4 commits July 4, 2019 15:22
Add a test which demonstrates a bug where if a scenario is loaded from
a directory that the `proxyaddr` is never set.
Thanks to @y-luis for originally finding and fixing this problem.
The original PR (#35) was discarded accidentally.
@goodboy
Copy link
Member Author

goodboy commented Jul 4, 2019

Dropped pypy in CI as per #52 and #51 to get this moving!

@goodboy goodboy merged commit 36a9b63 into master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxyaddr ignored
3 participants