Remove support for variable PCAP filenames #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @peter-oneill! Please add a release note. |
peter-oneill
force-pushed
the
remove-pcap-play-variable-filename
branch
from
bd179d8
to
b33903f
Compare
This was
linked to
issues
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #576, #610, #673
The original variable PCAP filenames PR #521 would free and rewrite a single per-scenario-action block of memory for every call, but all calls would continue referencing the memory. This led to various use-after-free issues. The PCAP play design also isn't set up for loading a file per call, so the solution didn't scale well.
This PR removes the variable PCAP filenames feature, while retaining the variable RTPStream filenames feature, which doesn't have the same issues.
Specific testing done:
<exec rtp_stream="my_audio.wav"/><exec rtp_stream="[field0]"/><exec rtp_stream="[command_line_key]"/>