Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XSS vulnerability #9

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Fix XSS vulnerability #9

merged 2 commits into from
Jul 15, 2019

Conversation

paulyi
Copy link
Contributor

@paulyi paulyi commented Jun 25, 2019

Description
Any HTML contained in msg will be rendered in the dom. This creates an XSS vulnerability if msg could be user input.

Solution
Insert msg as text. This will just display the string as is without trying to render any possible HTML contained within it.

@j1mmie
Copy link
Contributor

j1mmie commented Jul 8, 2019

@SLMNBJ Our team here discovered an XSS vulnerability in this repo. Any chance you are free to review this PR, merge, and re-release to NPM? If not, not biggie, we can fork the project. Let us know if we can help in any way

@paulyi
Copy link
Contributor Author

paulyi commented Jul 15, 2019

@SLMNBJ Just bumping one more time before we fork. Let us know if there's anything we can do to help.

@SLMNBJ SLMNBJ merged commit 927d81e into SLMNBJ:master Jul 15, 2019
@paulyi
Copy link
Contributor Author

paulyi commented Jul 24, 2019

@SLMNBJ Thank you for merging this in! If it's not too much trouble, could we get a new version published to NPM as well?

Let us know if there's anything you need from us.

@SLMNBJ
Copy link
Owner

SLMNBJ commented Jul 26, 2019

Hi @paulyi,

I published the new version on npm.

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants