Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anisotropic kernel for the multi-fidelity co-Kriging model (MFCK) #692

Merged
merged 15 commits into from
Dec 20, 2024

Conversation

mcastanoUQ
Copy link
Contributor

@mcastanoUQ mcastanoUQ commented Dec 11, 2024

Adding anisotropic kernel computation for the multi-fidelity co-Kriging approach proposed (MFCK) to deal with non-nested DoEs—additional modification adding a regularization parameter in the Negative Marginal Likelihood.

@relf
Copy link
Member

relf commented Dec 11, 2024

Please update title and description to reflect the PR content.

@mcastanoUQ mcastanoUQ changed the title Dev castano Anisotropic kernel for the multi-fidelity co-Kriging (MFCK) Dec 11, 2024
@mcastanoUQ mcastanoUQ changed the title Anisotropic kernel for the multi-fidelity co-Kriging (MFCK) Anisotropic kernel for the multi-fidelity co-Kriging model (MFCK) Dec 11, 2024
@Paul-Saves
Copy link
Contributor

Why did you modified the default value for cobyla ?

@mcastanoUQ
Copy link
Contributor Author

It's not necessary to have those values. I'll update the PR with the default values of Cobyla

Copy link
Member

@relf relf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the commented code removal, I will merge if you have nothing to add.

means.append(self.y_std * np.dot(beta1.T, alpha1) + self.y_mean)
covariances.append(k_xx - np.dot(beta1.T, beta1))

# k_XX_inv = np.linalg.inv(k_XX + self.options["nugget"]*np.eye(k_XX.shape[0]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this commented code.

@relf relf merged commit 27feb83 into SMTorg:master Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants