Add metric computation functions for surrogate performance evaluation #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relf
requested changes
Dec 17, 2024
| @@ -63,7 +63,7 @@ def standardization(X, y): | |||
| return X, y, X_offset, y_mean, X_scale, y_std | |||
|
|
|||
|
|
|||
| def compute_rms_error(sm, xe=None, ye=None, kx=None): | |||
| def compute_relative_error(sm, xe=None, ye=None, kx=None): | |||
There was a problem hiding this comment.
Yes this is a relative error not an RMSE
smt/utils/misc.py
Outdated
| return pva | ||
|
|
||
|
|
||
| def compute_rmse_error(sm, xe, ye): |
There was a problem hiding this comment.
This function name reads like "compute root mean squared error error". I suggest to remove "_error" from the functions names: compute_pva, compute_rmse and compute_q2
relf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.