Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API scripts, add pointer to SNflows/tendrils, continue re-organizing code. #49

Closed
3 of 5 tasks
emirkmo opened this issue Feb 17, 2022 · 1 comment · Fixed by #57
Closed
3 of 5 tasks

Remove API scripts, add pointer to SNflows/tendrils, continue re-organizing code. #49

emirkmo opened this issue Feb 17, 2022 · 1 comment · Fixed by #57

Comments

@emirkmo
Copy link
Member

emirkmo commented Feb 17, 2022

https://github.com/SNflows/tendrils is the new API endpoint.

Now a discussion should be had about which API endpoints should actually be in there (e.g., should photometry be its own separate module?) Should query TNS/Alerce/etc. get some functionality there? (I think so).

After we decide, then the ones from here should be removed, and a pointer should be added to README and onto the wiki/website.

Finally, there are a bunch of scripts here that are not really part of the flows photometry pipeline, but are more helper scripts for e.g. populating the marshal. I propose that they should be moved to either flows-tools, or a separate module. The end goal is to isolate only the photometry and related pipeline scripts here, make it a version LOCKED module, and then release it as stable V1.0. Until then we should go to v0.10, etc.

  • Move any remaining API-like scripts to tendrils (or decide where to put them, not in pipeline)
  • Decide on modules for tendrils (should photometry API be its own?, TNS? Alerce?)
  • Remove API scripts from flows pipeline, refactor code to reflect change.
  • Move non-pipeline scripts to a separate repo or sub-module (recommend repo so we can easily make a pipeline package from the remaining and LOCK all dependencies). Maybe a marshal repo, or into flows-tools. Such as run_querytns, run_ztf, plot_lc, etc.
  • Make V1.0 of photometry pipeline with as few dependencies as possible and with locked versions. Release as package.
@emirkmo
Copy link
Member Author

emirkmo commented Mar 6, 2022

The linked PR moves the API wrapper to Tendrils.

To make even less dependencies, some of the Runners should really be moved to a separate repo, probably flows-tools for now. (Such as run-querytns, run-ztf, etc.)

Eventually, they would make sense in a flows Webserver/Database repo. This repo can also have the python based API (ReST) that interacts with the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant