Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use Tendrils api, load_config, ztf, tns #57

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

emirkmo
Copy link
Member

@emirkmo emirkmo commented Mar 6, 2022

Move the above to tendrils as version 1 of the refactor.

Partially closes #49

Move the above to tendrils as version 1 of the refactor.
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #57 (0022a7f) into devel (289ecd5) will not change coverage.
The diff coverage is 48.27%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #57   +/-   ##
=======================================
  Coverage   29.15%   29.15%           
=======================================
  Files          36       36           
  Lines        2627     2627           
=======================================
  Hits          766      766           
  Misses       1861     1861           
Impacted Files Coverage Δ
flows/__init__.py 100.00% <ø> (ø)
run_catalogs.py 0.00% <0.00%> (ø)
run_photometry.py 0.00% <0.00%> (ø)
run_plotlc.py 0.00% <0.00%> (ø)
run_querytns.py 0.00% <0.00%> (ø)
run_upload_photometry.py 0.00% <0.00%> (ø)
flows/tns.py 27.77% <44.44%> (ø)
flows/aadc_db.py 100.00% <100.00%> (ø)
flows/catalogs.py 33.69% <100.00%> (ø)
flows/load_image.py 35.38% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289ecd5...0022a7f. Read the comment docs.

@emirkmo emirkmo self-assigned this Mar 7, 2022
Copy link
Member Author

@emirkmo emirkmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works to remove the API to tendrils for now, but runners remain.

@emirkmo emirkmo merged commit 6d3e15d into devel Mar 7, 2022
@emirkmo emirkmo deleted the refactor_tendrils_v1 branch March 7, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove API scripts, add pointer to SNflows/tendrils, continue re-organizing code.
1 participant