Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ratir to load_image #63

Merged
merged 2 commits into from
Apr 30, 2022
Merged

add ratir to load_image #63

merged 2 commits into from
Apr 30, 2022

Conversation

emirkmo
Copy link
Member

@emirkmo emirkmo commented Apr 26, 2022

I'm in the middle of a big refactor of Devel but needed to add RATIR as an instrument, so I am hoping I can merge this into Master after some tests.

@lgalbany should let me know though if the headers will be correct or not for the FILTER, or if I should also add in logic for dealing with their dual filter name headers.

It has also been added as site with id=23 on the flows website/database.

@emirkmo emirkmo requested a review from rhandberg April 26, 2022 18:42
@emirkmo
Copy link
Member Author

emirkmo commented Apr 26, 2022

@rhandberg tagging you so that you can pull this when it's ready and if it looks ok.

The refactor also had me mess with the github actions so there are some with the regular release things.

@emirkmo
Copy link
Member Author

emirkmo commented Apr 28, 2022

Tests failed due to LFS bandwidth, which I upgraded now..

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #63 (b8bde28) into master (8ae3b05) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   29.14%   29.14%   -0.01%     
==========================================
  Files          36       36              
  Lines        2628     2632       +4     
==========================================
+ Hits          766      767       +1     
- Misses       1862     1865       +3     
Impacted Files Coverage Δ
flows/load_image.py 34.67% <0.00%> (-0.72%) ⬇️
flows/version.py 52.63% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae3b05...b8bde28. Read the comment docs.

@emirkmo emirkmo merged commit e547d13 into master Apr 30, 2022
@emirkmo emirkmo deleted the add_RATIR branch August 9, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant