Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#230 add user to flat #265

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Feature/#230 add user to flat #265

merged 5 commits into from
Apr 20, 2020

Conversation

rfro377
Copy link
Contributor

@rfro377 rfro377 commented Apr 20, 2020 •
edited
Loading

Pull Request Information

Closes #230

What is the PR Type:

Feature

Describe the added/fixed behaviour:

Allows a logged-in user to add another user to their flat.

Checklist

  • Pull request has suitable title and labels, adequately described and associated with a github issue
  • Branch name follows correct convention (e.g. feature/#[id]-some-feature)
  • Branch builds and executes with no errors
  • Test cases have been generated for the feature and test cases pass
  • Updated relevant wiki/documentation

Additional Information

@rfro377 rfro377 requested a review from tant836 April 20, 2020 03:00
tant836
tant836 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@tant836 tant836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

williamlixu
williamlixu approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@williamlixu williamlixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamlixu williamlixu merged commit 1e429c1 into SOFTENG701G1:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tant836 tant836 tant836 approved these changes

@williamlixu williamlixu williamlixu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add member to flat
3 participants
@rfro377 @williamlixu @tant836