Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit the error instead of slient swallow it #193

Merged
merged 1 commit into from
Apr 8, 2015

Conversation

xujihui1985
Copy link
Contributor

I got kafka-node:zookeeper Exception: CONNECTION_LOSS[-4] error
sometimes, and the error sliently swallowed so it can not be catched

I thought the error should be thrown instead of been sliently swallowed.

I got kafka-node:zookeeper Exception: CONNECTION_LOSS[-4] error
sometimes, and the error sliently swallowed so it can not be catched
@haio
Copy link
Member

haio commented Apr 8, 2015

Thanks! @xujihui1985

haio added a commit that referenced this pull request Apr 8, 2015
fix: emit the error instead of slient swallow it
@haio haio merged commit a5c04e7 into SOHU-Co:master Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants